Ok I had a look at the code and find out why it doesn't work for French user.

1°) the skill on which everything is based, is the english term and not the one in the localized language. This is very easy to adapt this: just had a line in the missing.php file

Code: Select all

$skill = $wordings[$roster_conf['roster_lang']][$skill];

This give the translation of the skill as mentioned in the DB.

2°) You are using http://wow.allakhazam.com as source for the different recipes. The same service exists for french WoW available on http://www.wowdbu.com:
this is the table as it must look for french:

Code: Select all

switch($skill)
   {
      case 'Alchemy':
         $url = 'http://www.wowdbu.com/index.php?cat=70&id=75';
         break;
      case 'Blacksmithing':
         $url = 'http://www.wowdbu.com/index.php?cat=70&id=77';
         break;
      case 'Cooking':
         $url = 'http://www.wowdbu.com/index.php?cat=70&id=74';
         break;
      case 'Enchanting':
         $url = 'http://www.wowdbu.com/index.php?cat=70&id=72';
         break;
      case 'Engineering':
         $url = 'http://www.wowdbu.com/index.php?cat=70&id=73';
         break;
      case 'Firstaid':
         $url = 'http://www.wowdbu.com/index.php?cat=70&id=78';
         $skill = 'First Aid';
         break;
      case 'Leatherworking':
         $url = 'http://www.wowdbu.com/index.php?cat=70&id=76';
         break;
      case 'Tailoring':
         $url = 'http://www.wowdbu.com/index.php?cat=70&id=71';
         break;
      default:
         $url ='';
         break;
   }


For the rest I'm not a php expert ... so can you help me in order to make your wonderful tool also available for another part of the community?

The allakhazam page is parsed for the right data. Since wowdbu almost certainly uses a different layout, you'd have to rewrite the parser.

* Checks wowdbu and its source code

yuk. I'm not gonna write a parser for that.

what about this one buffed.de for german localization???


*hopes*

SethDeBlade wrote:what about this one buffed.de for german localization???


*hopes*

The source doesn't look too bad to me

But then again I'm a reg_ex noob and wouldn't know how to parse this if my life depended on it

I regex parser for both sites is surely possible, but buffed.de does not include levels so the colouring wouldn't work.

It also seems the french one is a little lacking in information.

the level is available but "only" in the recipescroll-tooltip if there is one. when there is non that means that the resipe can be learned at a trainer.

perheps its possible do get the level fom the tooltip and write "Trainer" if there is no scroll shown?

Yes that's possible but even at a trainer in requires a level to learn I'll have a poke around and see what I can come up with.

Maurd wrote:This new version appears to be bugged out. The table shows both the product and the recipe. Also, I know all of the current Alchemy recipes in the game. When I looked at my profile before, it showed me a handful of beta recipes that no longer exist. When I look at my profile now, only some of those beta recipes are shown. Seems like you need to refine or revert your search/parsing.

I linked to the recipe AND the end-result item on purpose. It's to get item info (on the end-result thing), and a link to the recipe so you can see where to get it.

Yes, I removed a handful of the beta recipes with one line, by checking it's icon. For me to remove all of them will take time. I simply flat out parse the data, I don't check names. I think in the future I will be moving to an sql based solution, so there will be no more parsing.

foreseit: Since it blindly parse's the file, I would have to completely re-write it, and parsing will not work with it. This won't be fixed until I figure out how I want to do this in the long run (probably a huge sql table with all the craftable items in it).

All: Sorry about localization. It took almost 2.5-3 days just to accurately parse Allhakazam's data, and they are about the most "standard" when it comes to html. Thottbot is horrible, every page is different. AFAIK, almost all wow site's are the same way. If you can find one that the same format is used on EVERY page, with localization, I would be more than happy to switch to it. Right now, it just isn't possible, and I"m sorry for that.

Fantastic addon! In my opinion this is one of only a few addons that provide real incentive for players to upload.

I like the direction its headed too. LVL and itemstats... I feel strongly that "Made By" and "Missing Recipes" should be combined and added to Roster as "Recipes". Even if they only share the same front end and work independently. A column of what i have and dont have on the same page would be nice.


Anyone have a complete list of beta junk for all professions and a SQL script to clean it out?

As webmaster im gonna get all kinds of ppl shouting why is that addon telling me i dont have a beta recipe -or- where can i find that?

For an Alch, these need to go:

Elixir of Tongues
Alchemist's Stone
Cowardly Flight Potion
Elixir of Waterwalking
Greater Holy Protection Potion
Refined Scale of Onyxia


Thanks to all of you!

Diska wrote:Not entirely correct, Restorative Potion is an existing recipe. It's a quest reward from a quest in Loch Modan.

Edited to remove restorative.

zeryl wrote:I linked to the recipe AND the end-result item on purpose. It's to get item info (on the end-result thing), and a link to the recipe so you can see where to get it.

Ah, ok. Without knowing it was added to the new version on purpose, it looked like it was doing it on accident through simple name parsing or something, since the original version did not behave that way. Thanks for the info.

Yes, I removed a handful of the beta recipes with one line, by checking it's icon. For me to remove all of them will take time. I simply flat out parse the data, I don't check names. I think in the future I will be moving to an sql based solution, so there will be no more parsing.

That's fine. I didn't mean to imply that you should get rid of them entirely. It just seemed strange that some disappeared between versions while others did not. They didn't bother me being there in the first place, as it was kind of fun to see some of the things they thought about putting in and then didn't.

Anyhow, great work on the addon. It warms my OCD heart.

Hello,

a better site for the german localisation as buffed.de is
http://wowhandwerk.onlinewelten.com/rec ... ession=171
for example. It are the same profession numbers, includes
levels for the item to make it and how everybody can learn it (recipies).

So, can anybody change the code for WoWHandwerk.onlinewelten.com?

I had try it, but it's not really my world to script with regex.

Thanks.


Greetings,
Darki0815

Wonderful addon really!

Talking of suggestions... I would really love a button that would "bridge the result of a search with the bank. Namely after a search is performed this should filter the missing recipes of a character from the bank content, making it clear for that user what recipes the bank has in stock that he could learn.

Actually this is something I have been looking for for quite some time, so I would really love to see it done :-).

Cheers,
Andrea

Love this addon, absolutely fantastic!

Perhaps it's an idea to make a blacklist with non-existing recipes to get rid of them?

majhlex wrote:For an Alch, these need to go:
...
Restorative Potion
...

Not entirely correct, Restorative Potion is an existing recipe. It's a quest reward from a quest in Loch Modan.

I plan on adding in a "blacklist", but it just hasn't happend yet, and I'm sorry about it.

I will try to get that done for you this weekend, but no guarentees with my work schedule.

no worries, i'm not in a hurry