Hi, I couldnt find this in any search I ran on the site so I figured I'd give this a shot.

All the Warriors in my guild are getting the same strange damage rating in the roster:

|cffff2020150

Its not a huge deal but I was wondering if any one else has had this problem and if there was a fix, or possibly something in the next version that will fix this.

I've noticed the same thing! I posted it up in the data accuracy forum though. And now that you mention it it's NOT thunderfury. It is just all warriors.

http://wowroster.net/Forums/viewtopic/t=829.html

It's not happening for all warriors because my warrior doesn't have this problem.

yeah I saw that post there but wasnt sure if it ment the same thing. I did searches for warrior damage and the weird number (the number itself not the word weird number,lol) and didnt come up with any thing on either. also didnt know if it would be considered data accuracy or not, which is why I posted it as general.

I figured it wasnt all warriors everywhere having this problem cause I'm sure there would have been more of a fuss on here about it that I would have seen.. But so far the warriors in my guild who have uploaded their proflies have gotten this rating on their profile.

Its not just warriors.

http://www.voodooreborn.com/modules.php ... %20Council

Its any class which has a +damage weapon that is not being calculated correctly. In my case, my wand is throwing off my ranged damage badly.

On another character:
http://www.voodooreborn.com/modules.php ... %20Council

Things still aren't right.

That's WoW coloring code
It's just missing the last part

Code: Select all

|cffff2020TEXT|r
^ ^       ^   ^
| |       |   |_End of coloring
| |       |_____Text
| |_____________Color code  AARRGGBB (Alpha, Red, Green, Blue)
|_______________Begin coloring

I think that calvin isn't striping out this information on this data

Same issue with at least one of the profiles on my site, even after upgrading to CP 1.6.0.

Is there a fix yet?

This happens if you have a buff to damage

If the buff goes away, then the data will look correct

I tested this with mocked up data based on zanix's post about the color codes.

In lib/wowdb.php, replace the following:

Code: Select all

if( !empty($attack['DamageRange']) )
        $this->add_value( 'melee_range', $attack['DamageRange'] ); 

With this:

Code: Select all

if( !empty($attack['DamageRange']) )
{
        $attack['DamageRange'] = preg_replace('/\|c[0-9a-f]{8}(.*?)\|r/i', '\1', $attack['DamageRange']);
        $this->add_value( 'melee_range', $attack['DamageRange'] );
}
 

Then replace the following:

Code: Select all

if( !empty($attack['DamageRange']) )
        $this->add_value( 'ranged_range', $attack['DamageRange'] ); 

With this:

Code: Select all

if( !empty($attack['DamageRange']) )
{
        $attack['DamageRange'] = preg_replace('/\|c[0-9a-f]{8}(.*?)\|r/i', '\1', $attack['DamageRange']);
        $this->add_value( 'ranged_range', $attack['DamageRange'] );
}
 

Updated: changed patterns to be case insensitive.

I'm going to see if I can get my guildmates to upload their profiles again unbuffed to test what zanix said about the buffed damage before i go in and alter the php if that works then its no biggie, if not at least i can do the php fix