[1.7.0-solved] Last Online Showing Dec 31 7:00 PM

by **danthehut** » Thu Aug 10, 2006 2:36 am

When updating the roster for my guild I get the following in the Last Online columns for people that are online when I save the data in game:

Dec 31 7:00 PM

http://moredots.trogdor.us/moredots/

I checked the characterprofiler file and see this for the user in question:

["Members"] = {
["Peppermd"] = {
["Note"] = "Dan alt",
["Zone"] = "Wetlands",
["Group"] = "no",
["Class"] = "Priest",
["LastOnline"] = {
["Day"] = 0,
["Month"] = 0,
["Hour"] = 0,
["Year"] = 0,
},

Is this by design or am I missing something here?

by **danthehut** » Thu Aug 10, 2006 2:37 am

just for reference, here are my version #'s.

["DBversion"] = "1.5.1",
["Version"] = "1.5.1",
["GPprovider"] = "rpgo",
["GPversion"] = "1.5.1",

by **danthehut** » Thu Aug 10, 2006 10:14 pm

So I think I've narrowed it down to the actual import into the DB.

The raw mysql data shows the following for this entry:

+---------------------+
| last_online |
+---------------------+
| 1969-12-31 19:00:00 |
+---------------------+

So I guess I'll need to dig through the update.php file to find the parsing of the lua file and the insert into the DB.

If anoyne comes across this and happens to know a fix or the reason let me know. Otherwise I'll post what I get when I've managed to iron it out.

by **glacius** » Thu Aug 10, 2006 11:12 pm

I have a similar issue ... some show correct others not.

by **Jorich** » Wed Sep 06, 2006 3:57 pm

I too have had this problem for quite some time, even earlier than Roster 1.7
I think that it happens when you upload a guild scan that has guild members that are still online at the time of that scan.
Not sure if this can be fixed in the update.php or if it's something with SQL.
Would definitely like to see this fixed however.

by **GuaRRand** » Wed Sep 06, 2006 4:59 pm

Ditto.
Mine show 1 Jan in some cases.

by **Jorich** » Thu Sep 07, 2006 6:02 am

This might help:

PHP mktime function

If you scroll down, there is something about negative values with this function.
Could this have something to do with it?

by **zanix** » Sun Sep 17, 2006 7:01 am

I figured out why this isn't working and is now fixed in the SVN

In lib/wowdb.php
function update_guild_member()
Find (around lines 1711 - 1719)

Code: Select all: $timeString = '-'; if ($lastOnlineYears > 0) $timeString .= $lastOnlineYears.' Years '; if ($lastOnlineMonths > 0) $timeString .= $lastOnlineMonths.' Months '; if ($lastOnlineDays > 0) $timeString .= $lastOnlineDays.' Days '; if ($lastOnlineHours > 0) $timeString .= $lastOnlineHours.' Hours ';

Replace with

Code: Select all: $timeString = '-'; if ($lastOnlineYears > 0) $timeString .= $lastOnlineYears.' Years '; if ($lastOnlineMonths > 0) $timeString .= $lastOnlineMonths.' Months '; if ($lastOnlineDays > 0) $timeString .= $lastOnlineDays.' Days '; $timeString .= max($lastOnlineHours,1).' Hours ';