Error description: I don't have the error message for this one anymore, but I believe it was an "S_RESPONSE" doesn't exist PHP warning message on the following page:
page: /roster/index.php?p=rostercp-armory_data&a=g:1
Suggestions:
- Code: Select all
Index: admin/armory_data.php
===================================================================
--- admin/armory_data.php (revision 2215)
+++ admin/armory_data.php (working copy)
@@ -157,6 +157,10 @@
)
);
}
+else
+{
+ $roster->tpl->assign_var('S_RESPONSE',false);
+}
$roster->output['title'] .= 'Armory Data';
Error description: Some armory requests don't work if you don't have a trailing / on your armory url in configuration.
Suggestion:
The way it is written now it manually adds the / for each URL, but for example, even the three right below where it is defined are missing it so that method fixes some URLs and not others. The better solution is to just add it in the initial definition.
- Code: Select all
Index: lib/armory.class.php
===================================================================
--- lib/armory.class.php (revision 2215)
+++ lib/armory.class.php (working copy)
@@ -165,7 +165,7 @@
global $roster;
$this->base_url = ROSTER_URL;//see if this works..$roster->config['website_address'].'/'; // gotta have a trailing slash here..... allways....
- $this->url_prefix_armory = isset($roster->data['armoryurl']) ? $roster->data['armoryurl'] : $this->url_prefix_armory;
+ $this->url_prefix_armory = isset($roster->data['armoryurl']) ? $roster->data['armoryurl'].'/' : $this->url_prefix_armory;
$this->url_prefix_char = $this->url_prefix_armory . $this->url_prefix_char;
$this->url_prefix_itemtooltip = $this->url_prefix_armory . $this->url_prefix_itemtooltip;
$this->url_prefix_talents = $this->url_prefix_armory . $this->url_prefix_talents;
@@ -186,17 +186,17 @@
if( $query === 'roster' )
{
$filename_type = 'guild-info';
- $url = $this->url_prefix_armory.'/'.$filename_type.'.xml?r=' . urlencode( $server ) . '&gn=' . urlencode( $guild );
+ $url = $this->url_prefix_armory.$filename_type.'.xml?r=' . urlencode( $server ) . '&gn=' . urlencode( $guild );
}
elseif( $query === 'character' )
{
$filename_type = 'character-sheet';
- $url = $this->url_prefix_armory.'/'.$filename_type.'.xml?r=' . urlencode( $server ) . '&cn=' . urlencode( $guildie);
+ $url = $this->url_prefix_armory.$filename_type.'.xml?r=' . urlencode( $server ) . '&cn=' . urlencode( $guildie );
}
elseif( $query === 'achievement' )
{
$filename_type = 'character-achievements';
- $url = $this->url_prefix_armory.'/'.$filename_type.'.xml?r=' . urlencode( $server ) . '&cn=' . urlencode( $guildie);
+ $url = $this->url_prefix_armory.$filename_type.'.xml?r=' . urlencode( $server ) . '&cn=' . urlencode( $guildie );
}
//$url_prefix_itemtooltip
elseif( $query === 'itemtooltip' )
I also have a bugfix to memberlist, I posted that separately under that addon:
topic6231.html
