All the icons used in the 'Log' column are broken for me. It seems to be looking for /<roster>/img/note.gif which does not exist.

Rendered code: <td id="as_status_log_5" class="membersRowCell"><img src="/roster/img/note.gif"onmouseover="return...

Also, the table collapse control icon in the top tight corner has a broken image link. It seems to be looking for /<roster>/img/minus.gif which does not exist
(same with /<roster>/img/plus.gif when the table is collapsed)

Rendered code: <img src="/roster/img/minus.gif" style="float:right;cursor:pointer;" id="update_details_img" onclick="toggleStatus();" alt="" />

this was the default path for the images in roster 2.0.1 ial have to find out where zanix moved them in 2.0.2

Ahh OK.. Found them.

roster\templates\default\images

Fix is

armorysyncjob.class.php
Line 584

Code: Select all

$icon = ROSTER_PATH. ( $status == 'ON' ? 'img/plus.gif' : 'img/minus.gif' );

to

Code: Select all

$icon = ROSTER_PATH. ( $status == 'ON' ? 'templates/default/images/plus.gif' : 'templates/default/images/minus.gif' );

Line 678-682

Code: Select all

                $array['LOG'] = "<img src=\"". ROSTER_PATH. "img/note.gif\"". makeOverlib( $member['log'] , $roster->locale->act['update_log'] , '' ,0 , '' , ',WRAP' ). " alt=\"\" />";
            } elseif( $member['log'] ) {
                $array['LOG'] = "<img src=\"". ROSTER_PATH. "img/note.gif\"". makeOverlib( "<div style=\"height:300px;width:500px;overflow:auto;\">". $member['log']. "</div>", $roster->locale->act['update_log'] , '' ,0 , '' , ',STICKY, WRAP, CLOSECLICK' ). " alt=\"\" />";
            } else {
                $array['LOG'] = "<img src=\"". ROSTER_PATH. "img/no_note.gif\" alt=\"\" />";

to

Code: Select all

                $array['LOG'] = "<img src=\"". ROSTER_PATH. "templates/default/images/note.gif\"". makeOverlib( $member['log'] , $roster->locale->act['update_log'] , '' ,0 , '' , ',WRAP' ). " alt=\"\" />";
            } elseif( $member['log'] ) {
                $array['LOG'] = "<img src=\"". ROSTER_PATH. "templates/default/images/note.gif\"". makeOverlib( "<div style=\"height:300px;width:500px;overflow:auto;\">". $member['log']. "</div>", $roster->locale->act['update_log'] , '' ,0 , '' , ',STICKY, WRAP, CLOSECLICK' ). " alt=\"\" />";
            } else {
                $array['LOG'] = "<img src=\"". ROSTER_PATH. "templates/default/images/no_note.gif\" alt=\"\" />";

and armorysync.js
Line 18

Code: Select all

showHide('update_details','update_details_img','img/minus.gif','img/plus.gif');

to

Code: Select all

showHide('update_details','update_details_img','templates/default/images/minus.gif','templates/default/images/plus.gif');

Only bit still broken is that if you click on the minus.gif to collapse the table the plus.gif link is broken as is the minus.gif link if you then click on what would've been the plus.gif. The toggle works, but the image path is still stuffed and I can't find where in the code I've missed.

It would be better to use the theme path variables so that if the use uses a different theme, the correct images will show from that theme

armorysyncjob.class.php
Line 584

Code: Select all

$icon = ROSTER_PATH. ( $status == 'ON' ? 'img/plus.gif' : 'img/minus.gif' );

to

Code: Select all

$icon = ROSTER_PATH. ( $status == 'ON' ? $roster->config['theme_path'] . '/images/plus.gif' : 'templates/default/images/minus.gif' );

Line 678-682

Code: Select all

                $array['LOG'] = "<img src=\"". ROSTER_PATH. "img/note.gif\"". makeOverlib( $member['log'] , $roster->locale->act['update_log'] , '' ,0 , '' , ',WRAP' ). " alt=\"\" />";
            } elseif( $member['log'] ) {
                $array['LOG'] = "<img src=\"". ROSTER_PATH. "img/note.gif\"". makeOverlib( "<div style=\"height:300px;width:500px;overflow:auto;\">". $member['log']. "</div>", $roster->locale->act['update_log'] , '' ,0 , '' , ',STICKY, WRAP, CLOSECLICK' ). " alt=\"\" />";
            } else {
                $array['LOG'] = "<img src=\"". ROSTER_PATH. "img/no_note.gif\" alt=\"\" />";

to

Code: Select all

                $array['LOG'] = "<img src=\"". $roster->config['theme_path'] . "/images/note.gif\"". makeOverlib( $member['log'] , $roster->locale->act['update_log'] , '' ,0 , '' , ',WRAP' ). " alt=\"\" />";
            } elseif( $member['log'] ) {
                $array['LOG'] = "<img src=\"". $roster->config['theme_path'] . "/images/note.gif\"". makeOverlib( "<div style=\"height:300px;width:500px;overflow:auto;\">". $member['log']. "</div>", $roster->locale->act['update_log'] , '' ,0 , '' , ',STICKY, WRAP, CLOSECLICK' ). " alt=\"\" />";
            } else {
                $array['LOG'] = "<img src=\"". $roster->config['theme_path'] . "/images/no_note.gif\" alt=\"\" />";

and armorysync.js
Line 18

Code: Select all

showHide('update_details','update_details_img','img/minus.gif','img/plus.gif');

to

Code: Select all

showHide('update_details','update_details_img',$roster->config['theme_path'] . '/images/minus.gif','templates/default/images/plus.gif');

ok ial make the changes

Hmmm... incorporating Zanix's changes broke everything for me again.

So with the code being:

Code: Select all

$roster->config['theme_path'] . 'images/minus.gif'

The resultant path of the broken image link became

Code: Select all

http://anthonyb.dyndns.org/roster//roster/templates/default/images/minus.gif

Seems the $roster->config['theme_path'] is not generating the right data - it's picking up an extra "/roster"

Yeah, I didn't actually test it
I use the variable on what it was supposed to be, guess it's a buggy variable

roster/lib/template.php

Code: Select all

$this->_tpldata['.'][0]['REQUEST_URI'] = str_replace('&', '&', substr(request_uri(),strlen(ROSTER_PATH)));
$this->root = ROSTER_TPLDIR . $this->tpl;
$roster->config['theme_path'] = ROSTER_PATH . 'templates/' . $this->tpl;

roster/lib/constants.php

Code: Select all

define('ROSTER_TPLDIR',ROSTER_BASE . 'templates' . DIR_SEP);

Hmm, 'theme_path' looks right...