so far its about 50% done.

How are you liking the development for a 2.0 addon compared to a 1.7.3 addon?

its so much better, every thing is allready layed out u did all the leg work.

Thanks, good to know

If you find anything missing in the new framework, or something missing on the AddOn SDK wiki page, please let us know, or add to the wiki yourself

k its all done but the update code. once i figure that out ill go over it a couple times to look for bugs.

ok its workin but i dont know how but it is. iam goin to try a few more new things out before i comb thu the addon.

If you have any questions about the framework, just ask

tryin to fix some php error's but havin no luck
here are a couple
Notice line 55: Undefined index: filter
Notice line 55: Undefined index: filter
Notice line 68: Undefined index: f

Code: Select all

    if( (isset($_REQUEST['filter'])) && (($_REQUEST['filter']) != 'All') )
                $query .= " AND guild_title='".$_REQUEST['filter']."'";

and the f is my link

Code: Select all

switch ($_GET['f'])
{
case 'full':

require ('pages/fullkarmahistory.php');

break;
}

so its like back to reading and looking up how to fix it.
i have 1 other and have no clue how to get it fixed is the one where i require ('./conf.php'); in the itemstats config to conn to the database i get
Notice line 14: Constant ROSTER_INSTALLED already defined
i need the conf.php to be a plug and play job if this error is ok ill over look it.

'filter' and 'f' notice errors
I dunno about these, isset($_REQUEST['filter']) should take care of it

Before using something in $_GET, you do need to check if the element exists first

I think I would need to see the whole file to figure this out


Itemstats

The variables set in conf.php are unset for a reason, security
And including conf.php tries to declare a constant that already exists, and hence the error

I think you can make itemstats use the same db link that Roster uses

Try this
Edit generic_itemstats.php
Find this (appears 2 times)

Code: Select all

    $item_stats = new ItemStats(); 

Replace with

Code: Select all

    global $roster;

    $GLOBALS['connectionId'] = $roster->db->link_id;
    $item_stats = new ItemStats(true); 

(I think we should integrate itemstats into Roster itself, but I hate their code so much and am tempted to code something better)

yeah that fixed the conn with roster
end code loks like

Code: Select all

global $roster, $addon;
 if ($addon['config']['useitemstats'] == 1)
  {
    
      $GLOBALS['connectionId'] = $roster->db->link_id;
      define('dbname', $roster->db->dbname);
      }
$item_stats = new ItemStats(true); 

hmm for some reason all them php error's i was geting got flushed away once i uploaded it to a server.
http://www.msimmers.com/roster
u can check it out but warn ya im still in the try and error so if ya get a no page try in a few min.
i was reading some where that local testing isnt a 100% anymore on php and that some error's will show and not once on a true server.
im tring to workin in the nice menu of roster but got handed a error once i allowed it to show

Code: Select all

Database Error: 
SQL:
SELECT count(`member_id`) AS `amount`, IF(`` LIKE '%%',1,0) AS 'isalt', FLOOR(`level`/10) AS label FROM `roster_members` WHERE `level` >= 30 GROUP BY isalt, label;
File: lib\dbal\mysql.php
Line: 234


im going to start blockin come pages from laoding and see where its at and go form there

What do you mean "im tring to workin in the nice menu of roster"

when i started coding things over to 2.0 i turned off all the options header, footer, menu to get a basic page layout. so once i got everything done i started turning them on and see what happens the menu broke my page.

k if any 1 wants to try it out it comes with no install readme. only 1 thing u need to do is put your database name in the config.php in itemstats before uploading and thats it. it installs like any other addon.
u can set the config settings once its installed.
u can find the link under the 1.7.3 section.
any devs want to look this over i would be happy.

I'll take a look at it