Feature request

GuildHistory displays the latest 100 actions taken by GuildProfiler from the guild event log

Moderator: Nefuh

Feature request

Postby tuigii » Fri Feb 29, 2008 5:23 pm

Nice feature, well done :D

I launch you a feature request : -)

What "should" be done...
From what I understood, you insert the entries as lines with an ID.
This ID can be used, but its merely an index [0..100] for the IG line entries.
Forget about these ID’s, or add them to the lines that are the most recent ones, like that, they correspond with the IG values.

What about this approach, in pseudo code:
Get the table (the 100 or less lines) from CP.lua
Find the last (from time point of view) line in your SQL table
Find the next, more recent line, in the CP.lua array – that isn’t in the SQL table.
Add all new values from CP.lua to SQL table from there.

Like this, the GuildHistory table will grow in time, and becomes a persistent Guild History log.

Better add an admin section that enables stripping for the last xx days (months) or xx max entries in the GuildHistory SQL table (or even both option for busy Guilds).
Or: let the table grow, but retrieve only the last XX lines at max for showing purposes.
This should be done because many shared web serves only offer 32 Mb of memory, and I already have a player with more then 6000 PvP logs => the server explodes when SELECTing that one ^^
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Feature request

Postby Nefuh » Fri Feb 29, 2008 7:41 pm

Hey tuigii,

nice ideas :)

At the moment the guildhistory is limited to 100 entries (the 100 from cp.lua) but the idea, to add these lines and get a big history log is good. I will do a recode (at the moment the update hook can´t handle it) and add more configuration options in roster configuration panel (like default sorting, max lines to display). And possible a search function.

Maybe i write this addon as a calendar (like the frontend from our event management system @ [removed link]).

When i used a calendar application, i can fetch only the records from the month who´s displayed.

Nefuh
Administrator of the german User2User Community for WoWRoster.
Guild Master from Scum from Hell - Horde @ EU-Anetheron.
User avatar
Nefuh
WoWRoster.net Dev Team
WoWRoster.net Dev Team
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 213
Joined: Fri Sep 15, 2006 8:34 pm
Location: Krefeld Germany

Feature request

Postby Anaxent » Sun Mar 02, 2008 2:49 am

And possible a search function.


This can be built right into the an addon search class which will auto load with roster and allow searching with in the main roster search function.
When building the class you will need to create a file {roster_dir}/addons/{addon_name}/inc/search.inc.php and if you need to get an idea on how to build this class you are welcome to take a look at the news, memberslist, or questlist search files which not only include a addon search but also have and allow advanced searches to narrow the search down along with custom formatting. The only thing that is currently missing from our search ability's is auth which is being worked on or atleast being thought out.
User avatar
Anaxent
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 642
Joined: Tue Jul 04, 2006 6:27 am
Location: Phoenix, Az

Re: Feature request

Postby Gyffes » Wed Nov 14, 2012 7:43 am

push

the feature from tuigii is great

Wäre super wenn du das machen könntest nefuh

grüße Sommy
Greet Gyffes

Thanks for help
Was nicht passt wird passend gemacht.
Image
User avatar
Gyffes
WR.net Apprentice
WR.net Apprentice
 
Posts: 45
Joined: Wed Sep 20, 2006 2:05 am

Re: Feature request

Postby Nefuh » Thu Nov 15, 2012 7:01 pm

Hallo Gyffes,

das Problem an der Sache wird wohl werden, das derzeit der WoWRoster-Profiler anscheinend das Gildenlog nicht speichert. Zumindest konnte ich in meiner wowrcp.lua keinerlei Daten finden. Ich weiß auch nicht ob es vorgesehen ist, das Gildenlog wieder zu speichern oder ob dies, von der Lua-API in WoW her, überhaupt noch möglich ist.

Derzeit wüsste ich auch kein anderes Addon, welches diesen Daten speichert.
Alles andere dürfte von ApiSync und dem normalen GildenInfo Addon abgedeckt werden.

Gruss Nefuh

English:

Hi Gyffes,

the problem is, that wowroster-profiler currently seems not to save the guildlog from game. I couldn´t find such data in my wowrcp.lua.
I don´t even know if Ulminia would add back this feature to profiler, nor if the ingame api currently allows to get this data by an addon.

Also i don´t know a alternate addon, which saves this data.
The rest should be done by ApiSync and the normal guildinfo addon.
Administrator of the german User2User Community for WoWRoster.
Guild Master from Scum from Hell - Horde @ EU-Anetheron.
User avatar
Nefuh
WoWRoster.net Dev Team
WoWRoster.net Dev Team
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 213
Joined: Fri Sep 15, 2006 8:34 pm
Location: Krefeld Germany

Re: Feature request

Postby Ulminia » Thu Nov 15, 2012 8:46 pm

it should be ..... and its sapose to but .. the option to allow dor deny the scanning is not in the config >< so it dose not you can bypass this by removing the following lines arround 3642
Code: Select all
if(not WoWRCP.db[xstat["_server"]]["Guild"][xstat["_guild"]]["EventLog"]) then
      WoWRCP.db[xstat["_server"]]["Guild"][xstat["_guild"]]["EventLog"]={};
   end
Ulminia of Zangarmarsh
Zonous of Zangarmarsh
Author of Roster Gallery
WoWRoster-Profiler Redesigner
User avatar
Ulminia
WoWRoster.net Dev Team
WoWRoster.net Dev Team
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 1223
Joined: Tue Jul 04, 2006 4:41 pm
Location: New Brunswick, Canada
Realm: Zangarmarsh (PvE) - US
gmail/gtalk: ulminia@gmail.com

Re: Feature request

Postby Gyffes » Fri Nov 16, 2012 3:23 pm

Also bei mir wird das mitgeloggt

I have no problems whit the event logging



Hier ein auszug aus der wowrcp.lua
here a part of the wowrcp.lua

Code: Select all
         ["EventLog"] = {
               {
                  ["Player1"] = "Zufällig",
                  ["Type"] = "demote",
                  ["Player2"] = "Jabberwocky",
                  ["Time"] = 1353071091,
                  ["LogTime"] = "0:0:5:13",
                  ["Rank"] = "Inaktiv",
               }, -- [1]
               {
                  ["Player1"] = "Zufällig",
                  ["Type"] = "demote",
                  ["Player2"] = "Xenoy",
                  ["Time"] = 1353071091,
                  ["LogTime"] = "0:0:5:13",
                  ["Rank"] = "Inaktiv",
               }, -- [2]
               {
                  ["Player1"] = "Tsabô",
                  ["Type"] = "invite",
Greet Gyffes

Thanks for help
Was nicht passt wird passend gemacht.
Image
User avatar
Gyffes
WR.net Apprentice
WR.net Apprentice
 
Posts: 45
Joined: Wed Sep 20, 2006 2:05 am

Re: Feature request

Postby Nefuh » Sat Nov 17, 2012 11:35 am

Hallo,

ich werde gleich mal meine bereits vorhanden wowrcp.lua löschen und neu anlegen lassen.
Dann werde ich mich mal an eine neue Version von GuildHistory setzen.

English:

Hi,

i´ll delete now my wowrcp.lua and create a new one.
Then i´ll start working on a new GuildHistory Version.
Administrator of the german User2User Community for WoWRoster.
Guild Master from Scum from Hell - Horde @ EU-Anetheron.
User avatar
Nefuh
WoWRoster.net Dev Team
WoWRoster.net Dev Team
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 213
Joined: Fri Sep 15, 2006 8:34 pm
Location: Krefeld Germany

Re: Feature request

Postby Gyffes » Sat Nov 17, 2012 1:56 pm

super
Greet Gyffes

Thanks for help
Was nicht passt wird passend gemacht.
Image
User avatar
Gyffes
WR.net Apprentice
WR.net Apprentice
 
Posts: 45
Joined: Wed Sep 20, 2006 2:05 am

Re: Feature request

Postby Nefuh » Mon Nov 19, 2012 8:26 pm

Hallo Gyffes,

die neue Version 2.3.0 des Addons ist nun verfügbar.
Ich habe vieles überarbeitet und einige neue Features ergänzt.

  • Abrufen der Daten nun per Ajax, für einen ausgewählten Tag (ausschaltbar)
  • Nur noch 2 Textformate (simple und extended)
  • Roster-Suchfunktionen integriert
  • Addondaten werden nun nicht jedesmal gelöscht, sondern das Addon fügt neue Daten nun hinzu ohne die alten zu löschen.
  • Auto Säuberungsfunktion für die Datenbank: In der Konfiguration kann nun eingestellt werden, welcher Zeitraum (in Monaten) behalten werden soll. Alle älteren Daten werden gelöscht. Standardmäßig steht diese Option auf "never", somit werden niemals Daten gelöscht.
  • Überarbeitetes Design: Es sollte nun nicht mehr so herausstechen und mehr in den Roster integriert sein.
  • Anpassbare Schriftgröße: In der Konfiguration kann nun ein wenig die Schriftgröße angepasst werden.
  • Generell werden nun die Daten nach Tagen gruppiert, sofern die Ajax Funktion abgeschaltet ist.

Download -> [hier klicken]

English:

New addon version 2.3.0 uploaded.
Many thinks are revised and some features are added:

  • Fetching addon data by ajax (disable by configuration)
  • Only 2 text formats (simple and extended)
  • Addon integrated into roster search
  • Addondata will be added to database, without deleting the old data.
  • Auto purge function: Set a period of time (in month) were data will be saved, all other data will be deleted. By default this option is set to "never", so no data will be deleted, only new data added.
  • Revised design: More like the main roster design
  • Editable font size: in configuration you can set the font size for the addon.
  • If ajax is turned off, data will be grouped by date and can be shown or hidden.

Download -> [click here]
Administrator of the german User2User Community for WoWRoster.
Guild Master from Scum from Hell - Horde @ EU-Anetheron.
User avatar
Nefuh
WoWRoster.net Dev Team
WoWRoster.net Dev Team
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 213
Joined: Fri Sep 15, 2006 8:34 pm
Location: Krefeld Germany

Re: Feature request

Postby Gyffes » Tue Nov 20, 2012 10:44 pm

Mh also bei mir funktioniert es nicht.

nach update der datenbank und natürlich auch ein erneutes Hochladen der wowrcp.lua
Zeigt er mir keine daten
Siehe http://ihl-gilneas.de/roster/index.php?p=guild-guildhistory&a=c:1

und beim Update der wowrcp steht auch immer da
Gildengeschichte

Verarbeite Eintrag 1 von 100 - Status: Veraltet
Verarbeite Eintrag 2 von 100 - Status: Veraltet
Verarbeite Eintrag 3 von 100 - Status: Veraltet
Verarbeite Eintrag 4 von 100 - Status: Veraltet
Verarbeite Eintrag 5 von 100 - Status: Veraltet
Verarbeite Eintrag 6 von 100 - Status: Veraltet
Verarbeite Eintrag 7 von 100 - Status: Veraltet




Is not Working for me
I have update the Plugin
I have rescan the guild an upload the wowrcp.lua
Greet Gyffes

Thanks for help
Was nicht passt wird passend gemacht.
Image
User avatar
Gyffes
WR.net Apprentice
WR.net Apprentice
 
Posts: 45
Joined: Wed Sep 20, 2006 2:05 am

Re: Feature request

Postby Nefuh » Wed Nov 21, 2012 11:03 am

Hallo Gyffes,

anscheinend ist bei Dir beim Upload des Addons etwas schief gelaufen, den die Datei /addons/guildhistory/inc/guildhistory.js ist bei Dir wohl nicht vorhanden oder kann nicht geladen werden.
Ich habe auch nochmal den Download hier geprüft in einem anderem Roster und alles funktionierte ohne Probleme.
Einfach das Addon nochmal neu hochladen und darauf achten, das keine Uploadfehler auftauchen.


English

Something went wrong on uploading the addon, roster couldn´t find the file /addons/guildhistory/inc/guildhistory.js or the file couldn´t loaded.

I´ve checked the downloaded archive from here, in another roster without any problems.
Try to reupload the addon and look if there are some upload errors during upload.
Administrator of the german User2User Community for WoWRoster.
Guild Master from Scum from Hell - Horde @ EU-Anetheron.
User avatar
Nefuh
WoWRoster.net Dev Team
WoWRoster.net Dev Team
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 213
Joined: Fri Sep 15, 2006 8:34 pm
Location: Krefeld Germany

Re: Feature request

Postby Gyffes » Wed Nov 21, 2012 5:40 pm

Nabend Nefuh,

So hab noch mal die datei runtergeladen entpackt und neu auf mein server geladen es gab keine fehlermeldung.

leider immer noch das selbe problem.
Die datei is vorhanden.


I have download the addon from here again and upload the addon on my server (no problems or bugy by the down and uoload)

i have the same Problem again.
Greet Gyffes

Thanks for help
Was nicht passt wird passend gemacht.
Image
User avatar
Gyffes
WR.net Apprentice
WR.net Apprentice
 
Posts: 45
Joined: Wed Sep 20, 2006 2:05 am

Re: Feature request

Postby Nefuh » Wed Nov 21, 2012 7:16 pm

Hallo Gyffes,

ok ich hab den Fehler gefunden...
Das ich den Fehler nicht reproduzieren konnte lag daran, das beide Roster Installationen in dehnen ich das getestet bzw. entwickelt habe, über eine eigene Subdomain verfügen. Nun habe ich bei der Pfadangabe für die Javascript-Datei nur "/addons/guildhistory/inc/guildhistory.js" angeben, somit sucht der die Datei vom Hauptordner ausgehend und nicht vom Roster Ordner.

Am einfachsten und schnellsten ist es die Datei "/addons/guildhistory/inc/guildhistory.class.php" wie folgt zu bearbeiten:

Zeile 138:

Ändere

Code: Select all
$script .= '<script type="text/javascript" src="/addons/guildhistory/inc/guildhistory.js"></script>'."\n";


in (nur ein Punkt vor der Pfadangabe)

Code: Select all
$script .= '<script type="text/javascript" src="./addons/guildhistory/inc/guildhistory.js"></script>'."\n";


Dies sollte das Problem beheben. Sorry das ich das total übersehen hatte beim ersten mal.

English:

I`ve found the error...
The problem was that my 2 roster installations are accessable by subdomains, so roster himself is in the main folder /.
In the script the path to the js file was set to "/addons/guildhistory/inc/guildhistory.js" so roster looks for the file from the main folder / which must not be the roster folder.

Solving the problem:

Just edit file "addons/guildhistory/inc/guildhistory.class.php" line 138:

Replace

Code: Select all
$script .= '<script type="text/javascript" src="/addons/guildhistory/inc/guildhistory.js"></script>'."\n";


with (just added a point to the path)

Code: Select all
$script .= '<script type="text/javascript" src="./addons/guildhistory/inc/guildhistory.js"></script>'."\n";


This should solve the error. I will upload a revised version in the next few minutes.
Administrator of the german User2User Community for WoWRoster.
Guild Master from Scum from Hell - Horde @ EU-Anetheron.
User avatar
Nefuh
WoWRoster.net Dev Team
WoWRoster.net Dev Team
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 213
Joined: Fri Sep 15, 2006 8:34 pm
Location: Krefeld Germany

Re: Feature request

Postby Ulminia » Wed Nov 21, 2012 8:21 pm

roster 2.3 has an awesome feature for js and css
changing nef's js include line to this
Code: Select all
roster_add_js( $addon['inc_dir'] . '/guildhistory.js');

will solve any server pathing issues and adds it to the roster cache for faster loading

Nef please translate for him
Ulminia of Zangarmarsh
Zonous of Zangarmarsh
Author of Roster Gallery
WoWRoster-Profiler Redesigner
User avatar
Ulminia
WoWRoster.net Dev Team
WoWRoster.net Dev Team
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 1223
Joined: Tue Jul 04, 2006 4:41 pm
Location: New Brunswick, Canada
Realm: Zangarmarsh (PvE) - US
gmail/gtalk: ulminia@gmail.com

Next

Return to GuildHistory

Who is online

Users browsing this forum: No registered users and 0 guests

cron