Give me all your item parser errors!

Posts from previous Beta sessions

Re: Give me all your item parser errors!

Postby shaun.voysey » Fri Feb 01, 2008 7:22 pm

A couple of Parser errors for you. I have cut down my cp.lua to the players data that is causing the problem.

Code: Select all
lib\item.php
  Roster Notice line 1271: Failed to Parse "Embossed Plate Shield of the Monkey": [9935:463:0:0:0:0:601:-1284999119] (enUS) colorToolTip() used
Mithril Spike (16-20)
  Roster Notice line 592: Item parser dataMithril Spike (16-20)
--------------------------------------------------------------------------------
 Embossed Plate Shield of the Monkey
Soulbound
Off Hand Shield
1408 Armor
20 Block
Mithril Spike (16-20)
|cffffffff+6 Agility|r
|cffffffff+7 Stamina|r
Durability 85 / 85
Requires Level 40


More detailed info in Attachments.

Happy Hunting. :)
Attachments
thian.lua
Characters CP.lua
(243.75 KiB) Downloaded 372 times
parse error.txt
Parser error Text
(3.3 KiB) Downloaded 314 times
User avatar
shaun.voysey
WR.net Apprentice
WR.net Apprentice
 
Posts: 70
Joined: Thu Aug 10, 2006 12:50 pm
Location: Berkshire, England

Give me all your item parser errors!

Postby Dyaxler » Sat Feb 02, 2008 12:27 am

I'm not entirely sure what you mean poetter... I get an actual parsing error window at the bottom of that characters profile page. At the moment I'm having issues sync'ing characters with gems in their gear so once thats resolved, I'll try and resync and check for an error again.
Dyaxler
WR.net Apprentice
WR.net Apprentice
 
Posts: 48
Joined: Sat Jan 05, 2008 4:51 pm

Re: Give me all your item parser errors!

Postby poetter » Sat Feb 02, 2008 9:55 am

Dyaxler wrote:I'm not entirely sure what you mean poetter... I get an actual parsing error window at the bottom of that characters profile page. At the moment I'm having issues sync'ing characters with gems in their gear so once thats resolved, I'll try and resync and check for an error again.


The problem is that i asked for parser problems for items uploaded via characterprofiler.lua. Your problem is related to a Armory item, which was obviously not working properly till tonight.

Items uploaded via ArmorySync will be handled later when I'm sure that everything's working fine.
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

Give me all your item parser errors!

Postby poetter » Sat Feb 02, 2008 9:59 am

@ shaun.voysey

You cut out to much, this file isn't parsable any more. Please repost the whole cp.lua
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

Re: Give me all your item parser errors!

Postby shaun.voysey » Sat Feb 02, 2008 1:17 pm

@ poetter

Whoops, Character Data for Thian Recreated from scratch. ;)

Easier than trying to cut out my other characters. :P
Attachments
thian characterprofiler.lua
Thians CP.
(247.45 KiB) Downloaded 335 times
User avatar
shaun.voysey
WR.net Apprentice
WR.net Apprentice
 
Posts: 70
Joined: Thu Aug 10, 2006 12:50 pm
Location: Berkshire, England

Give me all your item parser errors!

Postby poetter » Sat Feb 02, 2008 6:51 pm

Hi, uploaded your cp.lua and found no error. Did you update to latest svn?
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

Re: Give me all your item parser errors!

Postby shaun.voysey » Sat Feb 02, 2008 8:33 pm

@ poetter

I am using 1618, listed as 1614 in the version txt. Will update to latest when I get home.

Thians Character Sheet is

http://www.wowpublic.svweb.info/index.php?p=char-info&a=c:364

for current checking.



[Edit:] Have uploaded to SVN [1625] Seems to be fixed. Thanks for your help Poetter. Will now keep fully updated to latest SVN Now that I have a Tortoise. :P
Last edited by shaun.voysey on Sun Feb 03, 2008 7:08 pm, edited 1 time in total.
User avatar
shaun.voysey
WR.net Apprentice
WR.net Apprentice
 
Posts: 70
Joined: Thu Aug 10, 2006 12:50 pm
Location: Berkshire, England

Give me all your item parser errors!

Postby Subxero » Wed Feb 13, 2008 9:14 pm

Hi Poetter ;)

There are minor error if you want XHTML valid need some changes on tooltips

at "Gemmed Copper Gauntlets"
the tooltip have "<Random enchantment>"
the "<" and ">" need changed to htmlspecialchars or removed because http://validator.w3.org gets and error.

Later the socket images need to close the tag

"<img src="../Interface/ItemSocketingFrame/ui-emptysocket-red.jpg">  Red Socket<br />"

Only need to add a " /" before the ">"
Subxero - Priest 70 Holy - Asphelt Knight Officer - Zul'jin Horde.
User avatar
Subxero
WR.net Artisan
WR.net Artisan
 
Posts: 234
Joined: Thu Jul 06, 2006 4:08 pm
Realm: Zul'jin (PvE) - US

Re: Give me all your item parser errors!

Postby tuigii » Fri Feb 15, 2008 6:08 pm

This concerns frFR rosters.

Have a look at a recent LUA updated character.
=> http://www.papy-team.fr/roster/index.ph ... nfo&a=c:58

Line 600 in frFR.php doesn't do its job well.
This :
Code: Select all
$lang['tooltip_preg_socketbonus']='/Bonus de sertissage...(.+)\n/';

does work, when I modify de space : space for a triple dot (wild card).

Another example :
Another warrior, this time updated by a tool named ArmorySync :wink:
http://www.papy-team.fr/roster/index.ph ... fo&a=c:158

The parse problem ("Bonus de certissage.....") present in the first exemple isn't there anymore.

But a nice one shows up : the armor (= Armure in French) in the tooltip.
From LUA:
Armure : 548
From the Armory with the help of ArmorySync:
548 Armure
[neither one has a + sign - thats ok]
So, parsing fails in this case.
Is this a 'just for the French' inversion ? Is the Armory to blame ?
Can this be solved (inverted) in the ArmorySync addon ? (yes, it could)
Otherwise, the item parser should be adapted for this exeception (if nothing else works).

Another one (the second char, the ArmorySyc one)
Line 602 - frFR.php:
Code: Select all
$lang['tooltip_preg_durability']='/Durabilité (|:).(\d+) \/ (\d+)/';

Note the point (.) instead of a space.

A complicated one :
The original line is :
Code: Select all
$lang['tooltip_preg_block']='/(Bloquer).+?(\d+)/i';  // text for shield blocking values

Or, Armory(Sync) return the word Blocage, not Bloquer.
The Armory(Sync) syntax is 115 Blocage.
LUA says : Bloquer : 115

Some code is present (in item.php) to interchange the numeric value (i.e. 115) and the text string (Bloquer) but if Bloquer becomes Blocage, then stuff does go wrong :?

Please note : my roster is right now a clean 1665 version with the latest ArmorySync v2.6.0.346.

If you guys want to test, PM, and I PM ftp acces back.
Last edited by tuigii on Fri Feb 15, 2008 6:13 pm, edited 2 times in total.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Re: Give me all your item parser errors!

Postby poetter » Fri Feb 15, 2008 7:18 pm

Subxero wrote:Hi Poetter ;)

There are minor error if you want XHTML valid need some changes on tooltips

at "Gemmed Copper Gauntlets"
the tooltip have "<Random enchantment>"
the "<" and ">" need changed to htmlspecialchars or removed because http://validator.w3.org gets and error.

Later the socket images need to close the tag

"<img src="../Interface/ItemSocketingFrame/ui-emptysocket-red.jpg"> Red Socket<br />"

Only need to add a " /" before the ">"


Hi,

do you have an example for the first problem? Can find this one in the code.
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

Give me all your item parser errors!

Postby poetter » Fri Feb 15, 2008 7:47 pm

@tuigii

The amour and block problem is already solved in last AS svn. Haven't build a new zip yet. So, Nowwhat is parsed fully with AS!

@tuigii & subxero

Can you pm me your latest cp.lua? Both problems are easier to find on debugging, and I can't debug your sites. ;-)
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

Re: Give me all your item parser errors!

Postby tuigii » Fri Feb 15, 2008 9:08 pm

poetter wrote:The amour and block problem is already solved in last AS svn. Haven't build a new zip yet. So, Nowwhat is parsed fully with AS!

Already checked about 30 other in my Guild (the regular "UniUpLoader addicted guys" = lua updated)
Found nothing more.... Getting dammend close now :D

poetter wrote: Both problems are easier to find on debugging, and I can't debug your sites. ;-)


What ? - you threw away my ftp acces codes ? :D
I just PM'ed them to you.

Ils always nicer debugging and patching on a site that isn't yours "in case of" :wink:
Feel free to enter ...
Attachments
characterprofiler-lua.zip
Be carefull, 4 guys are living in here - 1 main, 2 bankers (loaded) and a no-namer-not Guilded type.
The Guild Vault is also in here (4 pages).
Proceded with CP & GP.
(117.3 KiB) Downloaded 306 times
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Give me all your item parser errors!

Postby poetter » Fri Feb 15, 2008 10:43 pm

No, the problem with debugging is, that i can't connect your php to my ide. ftp access won't help.

Anyway, thx for your lua!
Last edited by poetter on Sat Feb 16, 2008 6:15 pm, edited 1 time in total.
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

Give me all your item parser errors!

Postby poetter » Sat Feb 16, 2008 11:05 pm

@tuigii

I looked at your cp.lua and I'm confused. There really is some hidden crap in every tooltip in front of every ":". Don't know if that is a cp problem or a utf-8 one. Need to discuss this with the other devs
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

Give me all your item parser errors!

Postby poetter » Sat Feb 16, 2008 11:57 pm

Allright, we fixed this. Try svn[1679].
Image
User avatar
poetter
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 462
Joined: Sat Jun 30, 2007 9:41 pm
Location: Germany/Hamburg

PreviousNext

Return to Archived

Who is online

Users browsing this forum: No registered users and 1 guest

cron