[Solved] Alternative urls mode switching

Posts from previous Beta sessions

[Solved] Alternative urls mode switching

Postby tuigii » Wed Jan 09, 2008 9:25 pm

Switch to Alternative urls.
Visit some lists and Guild pages.

When switching from Alternative urls = On back to 'normal' mode = Off, the Alternative URL stays in place in the browser address bar.

But, with the Alternative mode URL still in place, something like
Code: Select all
http://www.papy-team.fr/roster/guild/memberslist/a=g:1.html

won't work well anymore.
And it isn't rewritten in classic layout neither.

Effect: the style sheet can't be found - a white background will be shown and no text formatting. Some images can't be found.

Going back to [site URL]/roster without any params will restore the view.

This is browser independent.
Last edited by tuigii on Wed Jan 09, 2008 10:35 pm, edited 1 time in total.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Alternative urls mode switching

Postby PleegWat » Wed Jan 09, 2008 9:49 pm

The effect with the URL staying in the access bar is known, and can't be easily avoided.
The problem with the links and stylesheets is because we only print the <base> tag in the header if SEO is on in roster. We had it on always printing for a while, but that was reverted. I'll try if I can find out while and get back to you.

File: templates/default/header.html.

Find:
Code: Select all
<!-- IF S_SEO_URL --><base href="{ROSTER_URL}" /><!-- ENDIF -->


Replace with:
Code: Select all
<base href="{ROSTER_URL}" />


Should fix the linking problem.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Alternative urls mode switching

Postby PleegWat » Wed Jan 09, 2008 9:54 pm

The <base> tag was removed for non-SEO in revision 1538, on 15 december 2007. The comment does not tell why this change was made. I'm not reverting it till I've contacted zanix about it.

Zanix, if you're reading this and I haven't spoken to you yet and you can't recall why this was reverted either, please apply the change in my previous post to SVN (or tell me to).
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Alternative urls mode switching

Postby PleegWat » Wed Jan 09, 2008 9:58 pm

Found it, it was this topic about roster's baseurl not containing the custom port. That issue is indeed fixed, so I'm reinserting the <base> tag when SEO is off.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

Re: Alternative urls mode switching

Postby tuigii » Wed Jan 09, 2008 10:32 pm

PleegWat wrote:Find:
Code: Select all
<!-- IF S_SEO_URL --><base href="{ROSTER_URL}" /><!-- ENDIF -->


Replace with:
Code: Select all
<base href="{ROSTER_URL}" />


Should fix the linking problem.

This works for me.

The issue seems to be resolved.
If Zanix could tell something about the side effects, or why this was done 15 dec 2007, then that would be great...

[edit] : ok, you already found it - "case closed"
Last edited by tuigii on Wed Jan 09, 2008 10:34 pm, edited 1 time in total.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France


Return to Archived

Who is online

Users browsing this forum: No registered users and 0 guests

cron