Typo in realmstatus.php SVN [1567]

by **Knevil** » Mon Jan 07, 2008 6:34 pm

in Line 233 there must be a ] after ['data'))

Code: Select all: switch( strtoupper($xml_server['category'][3]['data') )

but also with this new fix doesn't work for EU-Lordaeron

by **tuigii** » Mon Jan 07, 2008 9:11 pm

Knevil wrote:but also with this new fix doesn't work for EU-Lordaeron

But you found 1/3 of the missing parts ^^

Let's up this puppy :

Just after line 208:

Code: Select all: case 'REALM UP': $realmData['serverstatus'] = 'UP';

a break; is missing.

After line 243 add this :

Code: Select all: case 'FALSE': $realmData['serverpop'] = 'RECOMMENDED'; break;

Why ? In my case, a 'false' showed up for $xml_server['category'][3]['data']

Zanix still hopes the "Population info" is coming back, and it seems that way, but this value is also possible - so let's use it for now.

Now, mine works :wink:

BTW :
$xml_server['category'][3]['data'] is "Full" or "Recommened" for these EU servers :

Code: Select all: Full Found on : Al'Akir Full Found on : Bladefist Recommended Found on : Burning Legion Full Found on : Crushridge Full Found on : Daggerspine Recommended Found on : Frostmane Full Found on : GrimBatol Full Found on : Hellscream Recommended Found on : Kazzak Full Found on : Laughing Skull Recommended Found on : Magtheridon Full Found on : Molten Core Full Found on : Outland Full Found on : Quel'Thalas Recommended Found on : Runetotem Recommended Found on : Shadowmoon Full Found on : Shattered Halls Recommended Found on : Sporeggar Recommended Found on : Stormscale Full Found on : Sylvanas Full Found on : Terenas Recommended Found on : The Sha'tar Recommended Found on : Twilight's Hammer Full Found on : Warsong Full Found on : Arygos Full Found on : Das Konsortium Recommended Found on : Der Mithrilorden Recommended Found on : Frostwolf Full Found on : Mug'thol Recommended Found on : Onyxia Full Found on : Rajaxx Recommended Found on : Tirion Full Found on : Ysera Full Found on : Archimonde Full Found on : Chants eternels Full Found on : Eitrigg Full Found on : Krasus Recommended Found on : Les Clairvoyants Recommended Found on : Naxxramas Recommended Found on : Suramar Recommended Found on : Temple noir Recommended Found on : Uldaman Recommended Found on : C'Thun Full Found on : Dun Modr Full Found on : Los Errantes Recommended Found on : Minahonda Full Found on : Shen'dralar Recommended Found on : Tyrande Full Found on : Uldum Recommended Found on : Zul'jin

The list with $xml_server['category'][3]['data'] == 'false' is 185 lines long (still only EU servers):

Code: Select all: false Found on : Aerie Peak false Found on : Agamaggan false Found on : Aggramar false Found on : Ahn'Qiraj false Found on : Alonsus false Found on : Anachronos false Found on : Arathor ..... false Found on : Sinstralis false Found on : Throk'Feroth false Found on : Varimathras false Found on : Vol'Jin false Found on : Ysondre

We're getting somewhere now....

by **zanix** » Tue Jan 08, 2008 2:22 am

Both fixed svn[1571]

by **tuigii** » Wed Jan 09, 2008 9:57 pm

tuigii wrote:After line 243 add this :
Code: Select all
case 'FALSE': $realmData['serverpop'] = 'RECOMMENDED'; break;

Why ? In my case, a 'false' showed up for $xml_server['category'][3]['data']

Hummmm.
More logic is:

Code: Select all: case 'FALSE': $realmData['serverpop'] = UNKNOWN; break;

[go herefor a site / demo]

[edit] : removed 75 % of my post - see next post of Zanix for understanding : I was inventing a solution thjat was already present in SVN.... (lol)

The only thing that's left over, is that FALSE is more a 'UNKNOWN' as a 'RECOMMENDED' - but that a real small thing....

by **zanix** » Thu Jan 10, 2008 3:04 am

Look at the latest SVN, the config and locale strings are added for full and recommended

by **tuigii** » Thu Jan 10, 2008 4:10 am

zanix wrote:Look at the latest SVN....

Huge lol - I will next time.

So I tried to invent the wheel, that was already spinging alsewhere

This is a small sign for a great thing : the SVN becomes mature :wink: