Notify in say

Forum Dedicated to PvPLog, (The WoW PvP data collector addon), and PvPLog related topics

Moderator: bsmorgan

Notify in say

Postby zixs » Mon Jan 07, 2008 12:57 am

Well, I've tried to make on of those notify in /Say, but when I type say in the "Custom" box under the "Notify kills to:" it appears to be joining a channel named "say" and report it there, is there any way to make it report in normal Say message?

Thanks in Advance, Zixs
zixs
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Mon Jan 07, 2008 12:49 am

Re: Notify in say

Postby MattM » Mon Jan 07, 2008 3:58 am

Code: Select all
CHANGES

2008-01-06  * 2.4.9
    * Added PVPLOG.SAY -MattM
    * Added cbxPvPLogConfig_NotifyKillsSay -MattM

Code: Select all
TODO

1. Fix Feign Death bug.
2. Translations for PVPLOG.SAY


bsmorgan: If you want I can commit the changes to SVN
Last edited by MattM on Tue Jan 08, 2008 7:24 am, edited 3 times in total.
MattM
UA/UU Developer
UA/UU Developer
Gimpy Developer
Gimpy Developer
 
Posts: 886
Joined: Tue Jul 04, 2006 9:53 pm
Location: USA

Notify in say

Postby zixs » Mon Jan 07, 2008 4:48 am

Oh shit :O
That was fast, and I must say thanks a lot!
zixs
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Mon Jan 07, 2008 12:49 am

Notify in say

Postby bsmorgan » Tue Jan 08, 2008 7:24 am

This change has been incorporated into the official sources. Thanks Matt!

There was one small code fix and some comment changes so I've deleted the zip file included here. Please download from the normal location.

Regards,

Brad
User avatar
bsmorgan
WoW Interface Developer
WoW Interface Developer
 
Posts: 160
Joined: Tue Nov 28, 2006 10:17 pm
Location: Colorado Springs, Colorado

Notify in say

Postby MattM » Tue Jan 08, 2008 3:14 pm

people whine with output in say, while in AV

I'm guessing it's more useful for other reasons lol
MattM
UA/UU Developer
UA/UU Developer
Gimpy Developer
Gimpy Developer
 
Posts: 886
Joined: Tue Jul 04, 2006 9:53 pm
Location: USA

Notify in say

Postby Samadhi » Wed Jan 09, 2008 12:49 am

Can you imagine the spam if multiple people start using the say channel?

Can I respectfully submit that this is a bad idea? :(
Image
User avatar
Samadhi
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 114
Joined: Mon Jul 17, 2006 10:38 pm
Location: NJ, USA

Re: Notify in say

Postby bsmorgan » Wed Jan 09, 2008 4:16 am

Samadhi wrote:Can I respectfully submit that this is a bad idea? :(


If it wasn't a selectable option, I would agree. I've had people "complain" about my "spamming" of Party, Raid, Guild, and LocalDefense but fortunately, you can turn the notifications on and off for each or all of these channels (including Say).

I was most surprised by the complaints about my reports to LocalDefense. I don't know about other servers, but on mine, the LocalDefense conversation always goes something like:

PlayerA>I've been ganked, can someone help?
PlayerB>Where are you, what level were they?
PlayerC>What class?
PlayerD>Do you know what guild they are in?
Me>"Ganker (Level 70 Undead Rogue) killed me at [85,45] in Nagrand (Blades Edge Ruins)."
PlayerE>Me, can you quit the spamming in this channel?

Regards,

Brad
User avatar
bsmorgan
WoW Interface Developer
WoW Interface Developer
 
Posts: 160
Joined: Tue Nov 28, 2006 10:17 pm
Location: Colorado Springs, Colorado

Notify in say

Postby Samadhi » Wed Jan 09, 2008 4:27 am

I'm sure it's just my personal preference and I'd be the last person to complain about its use as an informational tool. Sadly, any good idea is invariably exploited for less-than-helpful ends by the masses.

The scenario that scares me is being in a BG where multiple folks have opted to use a public channel for their kill and death notifications. While I can filter my *own* output to those channels, I'd be forced to rely on /ignore to be able to filter out the spam.

I suppose that possibility already exists with every channel except say, though, so it's clearly not the end of the world. :)
Image
User avatar
Samadhi
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 114
Joined: Mon Jul 17, 2006 10:38 pm
Location: NJ, USA

Notify in say

Postby MattM » Wed Jan 09, 2008 7:07 am

Anything can be used for means less than (none, some, or all) of the player base thinks is "bad".

I like options more than limitations. I would leave it, and maybe make another option to automatically turn /say off when in certain situations, bg, etc.

I did notice that the script thinks you killed anyone you do damage to, even if it wasn't you who did the "killing blow".
Last edited by MattM on Wed Jan 09, 2008 7:09 am, edited 1 time in total.
MattM
UA/UU Developer
UA/UU Developer
Gimpy Developer
Gimpy Developer
 
Posts: 886
Joined: Tue Jul 04, 2006 9:53 pm
Location: USA

Re: Notify in say

Postby bsmorgan » Thu Jan 10, 2008 5:33 am

MattM wrote:I like options more than limitations. I would leave it, and maybe make another option to automatically turn /say off when in certain situations, bg, etc.


Such an option already exists for battlegrounds (and duels).

MattM wrote:I did notice that the script thinks you killed anyone you do damage to, even if it wasn't you who did the "killing blow".


I believe PvPLog has always worked this way.

While it may be possible to only credit "killing blow" kills, there are probably as many who would argue that this is as incorrect as those who argue that the present method is incorrect.

I'm guessing that PvPLog would have to build a list of "You have slain <name>" events and only credit the player with the kill if this event is present. It should be noted that Blizzard doesn't use this strict a definition for "honorable kills".
User avatar
bsmorgan
WoW Interface Developer
WoW Interface Developer
 
Posts: 160
Joined: Tue Nov 28, 2006 10:17 pm
Location: Colorado Springs, Colorado


Return to PvPLog

Who is online

Users browsing this forum: No registered users and 0 guests

cron