This also means the path access sig.php/Name.png does not currently work, use mod_rewrite to bypass forum image restrictions

The SEO syntax should work if mod_rewrite works, even if SEO is off in roster.

Use roster/char/siggen/member=xxx.png (/jpg/etc)

Yeah, true...

Is there a bug-thread already ?

I've got one, I think...
When activating Save images to server and this option Auto-save image on character update to 'yes' then I have a SQL error:
UPDATE `roster2_addons_siggen_config` SET trigger = '1' WHERE `config_id` = 'signature'
For figure why, because a
UPDATE `roster2_addons_siggen_config` SET guild_trigger = '1' WHERE `config_id` = 'signature'
is just ok.

SQL table field names are ok (trigger, guild_trigger or what ever).
When I do this :
[dirty hack inside - one line inserted]
siggen/inc/functions.inc (line 714)

Code: Select all

   if( $settingName != 'sc_op' && $settingValue != $configData[$settingName] )
   {
      $settingName ="`$settingName`";
      $sqlarray += array($settingName => $settingValue);
   }

I just back-tick the $settingName variable here on the fourth line - an SQL shuts its mouth, all is ok.
So, SQL is happy with this:

Code: Select all

UPDATE `roster2_addons_siggen_config` SET `trigger` = '1' WHERE `config_id` = 'signature'

Why, again, trigger is NO-GOOD and for example, guild_trigger is ok ?
Why is this patch needed (for me )
Isn't it not better to place this patch in the $roster->db->build_query() function ?

Anyway, I don't get it...

I could do a translation on the frFR.php .... I'll post one in the weekend.

PS : why not throwing this post in a bug-thread - because, even when siggen 0.3.0 realy looks great - it works ;-) - many posts will follow here - that's for sure.

PS2 : using MySQL: 5.0.32 - is trigger a reserved SQL word ?
Rename it character_trigger (because there is a guild-trigger) !

[edit] : Ok, got it. The 1.7.3 Siggen uses $wodb->add_value(...).
This function DOES add back-ticks arround the field names, so => no error.
$roster->db->build_query() (roster V2) doesn't.

Sorry for making this post a mess.

Special characters in servername are escaped three times causing a wrong image url:

At the moment:

Code: Select all

index.php/?p=util-siggen-siggen&mode=signature&member=MyName@EU-Mal\\\'Ganis


Working:

Code: Select all

index.php/?p=util-siggen-siggen&mode=signature&member=MyName@EU-Mal'Ganis


A accented character like:
Kränn@EU-Khaz Modan.png

Code: Select all

index.php?p=util-siggen-siggen&mode=signature&member=Kränn@EU-Khaz%20Modan

won't work neither.
It yields the generic "SigGen Works"

Counter solution : a simple

Code: Select all

http://www.papy-team.fr/roster_20b1/addons/siggen/sig/Kränn@EU-Khaz%20Modan.png

(using the saved signatures) does work, of course - if one saves the signatures (avatars) when updating the char (Guild).

Hmmm, I see the error with build_query()
I fixed it last night I think
And thanks for the frFR translation

As for the ///' and the missing %20...
I was having issues last night with this last night and url_encode wasn't working right

Hello ,

I have a problem with this version.

I have the latest version of roster 2 as from today and latest version of this mod as well.

All installed no problem , click on the siggen config , all sigs preview ok and display in the preview window, no problems here (apart from the ones currently known)

The problem is, on the roster then memberlist and choose a character, then click on the siggen icon and i get his displayed.

The module [char-siggen] does not exist

Any clues for this newbie please

LoL, I forgot a file

I'll get it added when I get home

Beta 2
- Attempt to fix improperly non urlencoded preview link
- Added missing char scope file
- Updated some comment headers
- Added direct file so you don't need to go to util-siggen-siggen, you can just use util-siggen

my sites up and runnen with the siggen beta.ulminia.zenutech.com click ulminia on the members list then the sigen button in the char menue and mine are worken and custom images are owrken too

hi all,

All is ok for me too

see my signature

siggen works for me as well.

but using save signatures with uniuploader upload doesnt work. In the output is written "- Could not save signature: function readfile() failed" even if the Uniuploader fix option is selected [edit: ok, just read the other topic about uniuploader and siggen]


and then a suggestion. I guess you are quite busy now with the roster and siggen but because now there is an additional page in character panel what about adding an background selector? depending on the background selected the img-url is changed. the possible backgrounds should be set by the admin.

Here a link of what i am thinking about. They made it like this. Just click on one of the images in the middelsection and the signature in the bottom od the moddelpart will change.

SethDeBlade wrote:using save signatures with uniuploader upload doesnt work. In the output is written "- Could not save signature: function readfile() failed" even if the Uniuploader fix option is selected [edit: ok, just read the other topic about uniuploader and siggen]

Yeah, I haven't tested SigGen with UU yet and I think I know why it doesn't work

SethDeBlade wrote:and then a suggestion. I guess you are quite busy now with the roster and siggen but because now there is an additional page in character panel what about adding an background selector? depending on the background selected the img-url is changed. the possible backgrounds should be set by the admin.

Here a link of what i am thinking about. They made it like this. Just click on one of the images in the middelsection and the signature in the bottom od the moddelpart will change.

Adding functionality like that would take a re-write I was planning and slowly working on for SigGen 1.0.0

Siggen 0.3.0b2 works with out any modifications in the new DragonflyCMS Port. Great job Zanix

yep its a very great job zanyx