Hey !

I have updatedet to 1485 from 1475, updatet the addons und wehn i click off memberlist come this :

Fatal error: Cannot redeclare class memberslist in /var/www/vhosts/boten-des-zorns.org/subdomains/roster/httpdocs/addons/memberslist/inc/memberslist.php on line 28

Link to the Roster :
http://roster.boten-des-zorns.org

Mehe, I already posted that in the thread DIRECTLY under yours ;-)

gettting the same error after upgrade

same error

Same here

i think all roster 2.0 users have the same problem

OK, this is likely to be my fault, but I don't really have the time to look at it extensively right now.

Can someone try going back one revision at a time (svn update -r <number>) and tell me what's the last one that worked?

EDIT: OK, I misunderstood the issue. This still worked when I last checked in. I'll yell at zanix tonight.

1480 definitely worked, and I think 1482 did as well - I'll check with the 83-84 ones as well when I have a spare moment at work.

Hey !

Here is au fix from Nefuh@wowroster.de thx !!

I believe the culprit is trunk\index.php in SVN[1484]. If you change it to the SVN[1483] version it works just fine again.

[EDIT]:Could it be that when the new code to check versions of addons starts a new instance of an addon's install class, one of those addons creates an instance of the memberslist class?

Yeah, I got the same result mdeshane - tried to post it earlier, when the fora decided to go blooey - Haven't had time to check the differences between 83 and 84 in the file though. :-)

The only difference in the files are these lines of code were added around line 113:

Code: Select all

if( $addon['active'] == '1' )
{
    // Check if this addon is in the process of an upgrade and deny access if it hasn't yet been upgraded
    $installfile = $addon['inc_dir'] . 'install.def.php';

    if( file_exists($installfile) )
    {
        include_once($installfile);

        if( class_exists($addon['basename']) )
        {
            $addonstuff = new $addon['basename'];

            // -1 = overwrote newer version
            //  0 = same version
            //  1 = upgrade available

            if( version_compare($addonstuff->version,$addon['version']) )
            {
                roster_die(sprintf($roster->locale->act['addon_upgrade_notice'],$addon['basename']) . '<br /><a href="' . makelink('rostercp-install') . '">'
                    . sprintf($roster->locale->act['installer_click_upgrade'],$addon['version'],$addonstuff->version) . '</a>',$roster->locale->act['addon_error']);
            }
        }
    } 

I personally think this change is a good idea since a not completely upgraded addon could have issues if someone tries to access it before the upgrade is complete

I'm willing to listen to suggestions

I have one already

Make the installer class be named addonnameInstall

I agree Zanix! I think this is a wonderful and useful addition! We just have a few bugs to work out... lol

So, for the install.def.php instead of:

Code: Select all

class addonname
{ 

it should now be:

Code: Select all

class addonnameInstall
{ 

Correct?