Question 1.
Are player ranks ONLY updated during a "guild" update? (please say yes!)

Question 2.
Assuming the answer to question 1 is yes, what would be the best way to detect a players rank change during the update process? For my mod to work successfully I'd need to know the players old and new rank.


-Vlorn

Yes

Get the rank data during a guild_pre hook

sudocode

Code: Select all

each( $member_id )
{
   $this->rank_ids += array(
      $member_id => $rank_id,
   );

Then get the rank data in a guild_post hook

Compare and act accordingly

You can also test in the guild hook, as the member's data will have been changed by the time this hook fires

sudocode

Code: Select all

if( $this->rank_ids[member_id] != $mermber_id )
{
   rank has changed!!
}
else
{
   rank has not changed!
}

How do I pass the array between functions guild_pre and guild?

-Vlorn

Store it in a class variable
Like $rank_ids

Then in each function, this variable can be accessed via $this->rank_ids

I would also research a bit on php classes, a good read might help out as well

sudocode

Code: Select all

class addonUpdate
{
   var $rank_ids = array()

   function guild_pre
   {
      $sql = SELECT `member_id`,`rank_id` from roster_members
      $result = sql_query($sql)
      while( $row = sql_fetch($result) )
      {
         $this->rank_ids += array(
            $row['member_id'] => $row['rank_id'],
         );
      }
   }

   function guild
   {
      if( $this->rank_ids[$member_id] != $current_id )
      {
         rank has changed!!
      }
      else
      {
         rank has not changed!
      }
   }
}

I had done that, my code originally looked very similar to what you proposed, but found the class variable was being cleared between guild_pre and guild. When I populated the variable in my Function call (the function named <addon>Update I was able to use the data in function guild.

Not sure what I was doing wrong to cause it to get cleared between function calls. probably something stupid.

-Vlorn

Hmm, that's weird

This might be a PHP 4/5 difference.
PHP 4 passes classes by copy by default.
PHP 5 always does it by reference.

The solution is probably explicitly passing the addonUpdate class by reference all the time, but I can't test on php4 myself.

Upgrading from php4 to php5 would also fix the issue.