Hi,

look at this:

Code: Select all

$method = (isset($roster->pages[1]) ? $roster->pages[1] : '');

$cont = (isset($_GET['cont']) ? $_GET['cont'] : '');

$errmsg = $result = '';


if( $roster->pages[1] == 'addon' )


Allright, so first parameter in url needs to be ajax to load ajax.php in /pages. Then the first line wants the method name, but some lines later the same line is taken as an indicator that roster has to load a addon.

So where to put my method call?

K, sorry.

/me slaps himself for committing code that hasn't been properly tested. Again.

0='ajax'
1='addon'
2=addonname
3=method

I'll fix it when I get home.

Can you publish a new release of roster afterwards? otherwise i have to wait for response till then.

poetter, you do know that, as an addon dev, you have read access to the roster1 repository (which contains roster 2.0)?

I can't push a nightly build myself, since only zanix can update the rosterdiag reference dir.

Yes i know. I can get the new file. But no one else that can give me response if ArmorySyncs Ajax functions are working.

BTW. Just changing the array index in line 21 won't do the trick. This way menuconf.js won't work anymore.

How about doing this?

Code: Select all

$method = (isset($roster->pages[3]) ? $roster->pages[3] : ( isset($roster->pages[2]) ? $roster->pages[2] : '' ) );


Fixed it for now. It uses index 1 by default, but index 3 if index 1 is equal to 'addon'.

I'm also moving the ajax.php to addons/AddonName/inc/ajax.php, to remain consistent and have all files in the addon root dir be util scope files.

Hmm found another bug:

try this:

Code: Select all

--- D:/xampp/roster.com/htdocs/pages/ajax.php.org   Sat Oct 06 22:29:44 2007
+++ D:/xampp/roster.com/htdocs/pages/ajax.php   Wed Oct 10 20:14:11 2007
@@ -18,7 +18,7 @@
 
 include(ROSTER_AJAX . 'functions.php');
 
-$method = (isset($roster->pages[1]) ? $roster->pages[1] : '');
+$method = (isset($roster->pages[3]) ? $roster->pages[3] : ( isset($roster->pages[2]) ? $roster->pages[2] : '' ) );
 
 $cont = (isset($_GET['cont']) ? $_GET['cont'] : '');
 
@@ -27,7 +27,7 @@
 
 if( $roster->pages[1] == 'addon' )
 {
-   $addon = getaddon($pages[2]);
+   $addon = getaddon($roster->pages[2]);
    // Check if addon is active
    if( $addon['active'] == '1' )
    {
@@ -89,4 +89,3 @@
    '  <status>'.(int)$status.'</status>'."\n".
    '  <errmsg>'.$errmsg.'</errmsg>'."\n".
    '</response>'."\n";
-


What about this?

Code: Select all

      $status = 2;
      include_once( $addon['ajax_file'] );
      if( $status == 2 )


Another bug or do you want me to set status != 2 in my ajax.php?

Yeah, just don't set status = 2
These are roster ajax error codes

I fixed the $pages thing too svn[1394]

OK, it just was'nt in 1377. Will this stay in ajax.php? And to make this clear. We#re talking about line 47 - 52. The call to the addons ajax.php with the method definitions.

THat construction somehow turned up for the native ajax usage, and got copy/pasted for the addons part. Set status back to 0 for now, i'll take a look and may change it tonight.