First:
Why to show only blue, yellow, red and meta?.
/index.php

foreach($roster->locale->act['GemType'] as $keyColor=>$couleur)
{
if (($keyColor == 'blue') || ($keyColor == 'red') || ($keyColor == 'yellow') || ($keyColor == 'meta'))
{

When we can show all them...

foreach($roster->locale->act['GemType'] as $keyColor=>$couleur)
{
if (($keyColor == 'blue') || ($keyColor == 'red') || ($keyColor == 'yellow') || ($keyColor == 'meta') || ($keyColor == 'green') || ($keyColor == 'purple') || ($keyColor == 'orange'))
{

Second:
Isn't it posible to don't show the box when any players have gems of this colour. It would be better without show the boxes empty and in the case where we haven't gems, show a text "we haven't gems".

Third:
/install.def.php

Can you localize the next lines?

var $fullname = 'Gems Display';
var $description = 'Display Gemmes by slot.';
var $credits = array(
array( "name"=> "Titan99 and Tyradil",
"info"=> "Display Gemmes by slot."),
);

The rest of addons are translated and it appears in english in the instalation addons menu.

Fourth:
The version is...

Code: Select all

var $version = '2.0.0-0';

or is?

Code: Select all

var $version = '2.0.0.0';

That's all

Nice catches
Your right on all of them.

But please, change your Subject line, so the author will see a direct :
Some comments [Gem Display Roster 2 addon]
or a
Some comments [Gems Display Roster 1.7.3 addon]

For roster's matching system, those two version numbers are equivalent. I personally prefer the former.

Changed the subject

maqjav wrote:First:
Why to show only blue, yellow, red and meta?.
/index.php

Code: Select all

foreach($roster->locale->act['GemType'] as $keyColor=>$couleur)
{
  if (($keyColor == 'blue') || ($keyColor == 'red') || ($keyColor == 'yellow')  || ($keyColor == 'meta'))
  {


When we can show all them...

Code: Select all

foreach($roster->locale->act['GemType'] as $keyColor=>$couleur)
{
  if (($keyColor == 'blue') || ($keyColor == 'red') || ($keyColor == 'yellow')  || ($keyColor == 'meta') || ($keyColor == 'green') || ($keyColor == 'purple')  || ($keyColor == 'orange'))
  {


I believe that this behaviour is intentional. It just depends on how you want to use the Gem Display addon. Currently it works great if you're looking for a Gem that matches a certain color. Eg. All gems that match a blue socket will be listed under blue gems, including purple and green gems.