bisaz wrote:got this too:

lib/update.lib.php
Notice line 389: strtotime(): Called with empty time parameter

and no memberdata changed after update...

i thought that changes to members arent made instantly so i decided to
run one complete update cycle and take a look again.

OK guys, can't reproduce this error:
lib/update.lib.php
Notice line 389: strtotime(): Called with empty time parameter

I need to know exactly what you where doing.

Did you upload cp.lua first?
Did you add a new guild with the tools button?
Did you do a guildmemberlistsync?
Did you do a guildsync?
Did you do a charsync?

So please give your exact steps to the problem. Your language, guildname and server would be helpful, too. If you don't want to post this data here, pm me.

It is working fine on my server. I'll say you are doing a great job so far. Maybe when you get the time you can fix it parser error.

okay im using roster 2.0 svn 1337 (leet edition )

newest armory 2.6 beta svn[224].

Guild: Schlachtenbummler
Server: Azshara
Region: EU

German Armory


i added my guild with the cp.lua one month ago and updated it today with
the guildmemberlistsync of armorysync.
i allready deleted all guilds with phpmyadmin and tried to readd it like this:
Utilities > Armory Memberlist Sync for a new Guild (pink icon).
after that i tried to do a full charsync but armory sync says:
Nothing to do at the moment


well back to the cp.lua added memberlist:
after that i started the charsync everything is running except the php error.

I might be able to help with this error

Line 389

Code: Select all

if( ( strtotime($time) - strtotime($timestamp) ) > 0 ) 

This line compares the timestamp in the CP file to the timestamp in the db

Line 321

Code: Select all

$timestamp = $char['timestamp']['init']['DateUTC']; 

Line 383

Code: Select all

$time = $roster->db->query_first("SELECT `dateupdatedutc` FROM `" . $roster->db->table('players')
      . "` WHERE    '" . $char_name . "' LIKE `name` "
      . " AND '" . $realm_escape . "' LIKE `server` "
      . " AND '" . $region . "' LIKE `region`;"); 

I can't tell from the error, but I think it might be because there is no data in the db and some servers might not like this

tuigii wrote:@ poetter

I presume I can throw away the file in the addons direcory named smf_diff.txt and anothjer one in the addons /armorsync, named guildadd.php ?

And yet another thing :
Strange things are going on with thiefs :
Look at this page :
http://www.les-potes-ages.fr/roster/cha ... er=Suramar
ad this one http://eu.wowarmory.com/character-skill ... titpartrax

Both are the same character. Note that there are no numbers, like 242/375 on the Armory pages for sec. classes.

Here is another thief, updated by UniUpLoader and the Armory Add On.
All is well : http://www.les-grands-croises.fr/roster ... member=121

And look at the skills tables of the same Guilde : http://www.les-grands-croises.fr/roster ... ns&guild=2
Only the thief character 'Papivol' is ok - the others have their lvl ok, but the 'max ' is '1' ?

A Blizzard mather ?

Hi, i think i can shift around that problem in setting the max to the same as the value. This will be done for poision and lockpicking only. Don't know if this correct by the way.

@zanix

This correct, but my server returns a bool 0 what will be a strtotime value of some around 1970. Is this a php version thing?

What php version are the people using getting this error?

i have: 4.4.7 :/

http://us2.php.net/strtotime

Down in the comments

shaver at qspeed dot com wrote:4) (Partially noted in changelog.) If you pass php4 an empty string it will error out with a "Notice: strtotime(): Called with empty time parameter". PHP5 will give no notice and return the current date stamp. (A much preferred behavior IMO.)

PHP 4 handles this differently than PHP 5

I'll fix this in the Roster updater

i solved it by removing the following:

roster/lib/update.lib.php
line 389

Code: Select all



                                                // Check if the profile is old
//                                              if( ( strtotime($time) - strtotime($timestamp) ))
//                                              {
//                                                      $output .= sprintf($roster->locale->act['not_update_char_time'],$char_name) . "<br />\n";
//                                                      continue;
//                                              }

the update runs perfectly and chars are getting updated.

This should work as well

Code: Select all

if( $time != '' && ( strtotime($time) - strtotime($timestamp) ) > 0 )

[EDIT]
UPS, false editing removed
[/EDIT by poetter]

im very sorry to post again ..

this is one of my updated chars:
http://schlachtenbummler.com/roster/ind ... &member=17

im going to sleep now ..

gn8

zanix wrote:This should work as well

Code: Select all

if( $time != '' && ( strtotime($time) - strtotime($timestamp) ) > 0 )

[EDIT]
UPS, false editing removed
[/EDIT by poetter]

I would prefer this solution ;-)

works zanix, thx and thx for this nice addon!

leusent wrote:im very sorry to post again ..

this is one of my updated chars:
http://schlachtenbummler.com/roster/ind ... &member=17

im going to sleep now ..

gn8

Nothing wrong here. If you meen the big debug tables in it, this belongs to the itemparser. see first post, read it and understand it!