svn[1314]Unable to turn debug ON

Posts from previous Beta sessions

svn[1314]Unable to turn debug ON

Postby boyo » Sat Sep 08, 2007 2:44 pm

It is not possible to turn debug mode back on after turning it off in the cp.
Manually changing it in the db in _config does work.

Debug currently off, attempting to turn on.
Code: Select all
SQL Queries
Line Time Query
lib/roster.php
  125 0.0004 SELECT `config_name`, `config_value` FROM `roster20_config` ORDER BY `id` ASC;
  387 0.0002 SELECT * FROM `roster20_addon`;
lib/login.php
  70 0.0002 SELECT * FROM `roster20_account` ORDER BY `account_id` DESC;
  160 0.0002 SELECT `account_id`, `name` FROM `roster20_account`;
lib/config.lib.php
  530 0.0003 SELECT * FROM `roster20_config` ORDER BY `id` ASC;
admin/roster_config_functions.php
  68 0.0002 SELECT `mb`.*, `a`.`basename`
FROM `roster20_menu_button` AS mb
LEFT JOIN `roster20_addon` AS a
ON `mb`.`addon_id` = `a`.`addon_id`
WHERE `scope` != 'char'
ORDER BY `mb`.`title`;
lib/functions.lib.php
  1043 0.0002 SELECT `config_name`, `config_value` FROM `roster20_addon_config` WHERE `addon_id` = '1' ORDER BY `id` ASC;
  1043 0.0003 SELECT `config_name`, `config_value` FROM `roster20_addon_config` WHERE `addon_id` = '2' ORDER BY `id` ASC;
  1043 0.0002 SELECT `config_name`, `config_value` FROM `roster20_addon_config` WHERE `addon_id` = '3' ORDER BY `id` ASC;
  1043 0.0002 SELECT `config_name`, `config_value` FROM `roster20_addon_config` WHERE `addon_id` = '4' ORDER BY `id` ASC;
  1043 0.0002 SELECT `config_name`, `config_value` FROM `roster20_addon_config` WHERE `addon_id` = '5' ORDER BY `id` ASC;
  1043 0.0002 SELECT `config_name`, `config_value` FROM `roster20_addon_config` WHERE `addon_id` = '6' ORDER BY `id` ASC;
lib/menu.php
  374 0.0002 SELECT count(`member_id`) AS `amount`, IF(`officer_note` LIKE '%ALT-%',1,0) AS 'isalt', FLOOR(`level`/10) AS label FROM `roster20_members` WHERE `level` >= 10 GROUP BY isalt, label;
  567 0.0003 SELECT `mb`.*, `a`.`basename` FROM `roster20_menu_button` AS mb LEFT JOIN `roster20_addon` AS a ON `mb`.`addon_id` = `a`.`addon_id` WHERE `a`.`addon_id` IS NULL OR `a`.`active` = 1;
  584 0.0002 SELECT * FROM `roster20_menu` WHERE `section` IN ('util','realm','guild') ORDER BY `config_id`;
addons/memberslist/inc/search.inc.php
  36 0.0004 SELECT `member_id`, `name` FROM `roster20_members` ORDER BY `name`;


Debug currently on, successfully turned off.
Code: Select all
SQL Queries
Line Time Query
lib/roster.php
  125 0.0004 SELECT `config_name`, `config_value` FROM `roster20_config` ORDER BY `id` ASC;
  387 0.0002 SELECT * FROM `roster20_addon`;
lib/login.php
  70 0.0002 SELECT * FROM `roster20_account` ORDER BY `account_id` DESC;
  160 0.0002 SELECT `account_id`, `name` FROM `roster20_account`;
lib/config.lib.php
  496 0.0661 UPDATE `roster20_config` SET `config_value` = '0' WHERE `config_name` = 'debug_mode';
  530 0.0011 SELECT * FROM `roster20_config` ORDER BY `id` ASC;
admin/roster_config_functions.php
  68 0.0002 SELECT `mb`.*, `a`.`basename`
FROM `roster20_menu_button` AS mb
LEFT JOIN `roster20_addon` AS a
ON `mb`.`addon_id` = `a`.`addon_id`
WHERE `scope` != 'char'
ORDER BY `mb`.`title`;
lib/functions.lib.php
  1043 0.0001 SELECT `config_name`, `config_value` FROM `roster20_addon_config` WHERE `addon_id` = '1' ORDER BY `id` ASC;
  1043 0.0002 SELECT `config_name`, `config_value` FROM `roster20_addon_config` WHERE `addon_id` = '2' ORDER BY `id` ASC;
  1043 0.0001 SELECT `config_name`, `config_value` FROM `roster20_addon_config` WHERE `addon_id` = '3' ORDER BY `id` ASC;
  1043 0.0001 SELECT `config_name`, `config_value` FROM `roster20_addon_config` WHERE `addon_id` = '4' ORDER BY `id` ASC;
  1043 0.0001 SELECT `config_name`, `config_value` FROM `roster20_addon_config` WHERE `addon_id` = '5' ORDER BY `id` ASC;
  1043 0.0001 SELECT `config_name`, `config_value` FROM `roster20_addon_config` WHERE `addon_id` = '6' ORDER BY `id` ASC;
lib/menu.php
  374 0.0002 SELECT count(`member_id`) AS `amount`, IF(`officer_note` LIKE '%ALT-%',1,0) AS 'isalt', FLOOR(`level`/10) AS label FROM `roster20_members` WHERE `level` >= 10 GROUP BY isalt, label;
  567 0.0002 SELECT `mb`.*, `a`.`basename` FROM `roster20_menu_button` AS mb LEFT JOIN `roster20_addon` AS a ON `mb`.`addon_id` = `a`.`addon_id` WHERE `a`.`addon_id` IS NULL OR `a`.`active` = 1;
  584 0.0001 SELECT * FROM `roster20_menu` WHERE `section` IN ('util','realm','guild') ORDER BY `config_id`;
addons/memberslist/inc/search.inc.php
  36 0.0003 SELECT `member_id`, `name` FROM `roster20_members` ORDER BY `name`;


I did see this from the announcements, but believe this to be an error in the changing of options, not the fact that the options dont do anything. If i'im wrong, I appologize.
PleegWat wrote:I've just committed a change that will force on all debug options. This change will be reverted before release.
Don't report the fact these rostercp options don't do anything as a bug. Instead, report the debug messages you're getting as bugs.
Last edited by boyo on Sat Sep 08, 2007 2:52 pm, edited 1 time in total.
boyo
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 103
Joined: Wed Jan 24, 2007 7:37 am

svn[1314]Unable to turn debug ON

Postby PleegWat » Sat Sep 08, 2007 6:51 pm

It seems it's not detecting the fact the config changed for that field, and some others I've tested. I'll look into it.

This is not related to the force debug on change.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm

svn[1314]Unable to turn debug ON

Postby PleegWat » Sat Sep 08, 2007 7:15 pm

My apologies. What's happening is this:

- The config is read from the DB, and the setting is off
- The force debug hack turns the setting on
- The config system compares the value you've selected (on) with the value of the current setting in memory (on).
- Since the configured value is the same as the current value in memory, the setting is not turned on, even though it's actually off.

- Later on, when the page is being rendered, the config is fetched again, this time including the metadata. The setting shows on the config page like it is in the DB (ie off).

There may be a way to fix this behaviour, but I'm not gonna bother because the hack is temporary anyway. Please report back if you encounter any trouble.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm


Return to Archived

Who is online

Users browsing this forum: No registered users and 1 guest

cron