svn[1268] php error and item parsing

Posts from previous Beta sessions

svn[1268] php error and item parsing

Postby rouven » Mon Aug 27, 2007 3:37 pm

lib/item.php
Code: Select all
  Warning line 934: preg_match() [function.preg-match]: Empty regular expression
  Roster Notice line 1197: Failed to Parse "Tückischer Kettenbrustharnisch des Adlers": [15536:18:0:0:0:0:863:-1968745269] (deDE) colorToolTip() used
Verstärkt (+32 Rüstung)
  Warning line 934: preg_match() [function.preg-match]: Empty regular expression
  Roster Notice line 1197: Failed to Parse "Ritterstiefel der Ausdauer": [7458:18:0:0:0:0:187:1035573318] (deDE) colorToolTip() used
Verstärkt (+32 Rüstung)
  Warning line 934: preg_match() [function.preg-match]: Empty regular expression
  Warning line 934: preg_match() [function.preg-match]: Empty regular expression
  Roster Notice line 1197: Failed to Parse "Beständige Beinplatten des Adlers": [15596:18:0:0:0:0:869:-1757344628] (deDE) colorToolTip() used
Verstärkt (+32 Rüstung)
  Notice line 1341: Undefined variable: armor_set
  Notice line 1342: Undefined variable: armor_set
  Notice line 294: Undefined index: roter
  Warning line 934: preg_match() [function.preg-match]: Empty regular expression
  Roster Notice line 1197: Failed to Parse "Tückischer Kettenbrustharnisch des Adlers": [15536:18:0:0:0:0:863:-1968745269] (deDE) colorToolTip() used
Verstärkt (+32 Rüstung)
  Warning line 934: preg_match() [function.preg-match]: Empty regular expression
  Roster Notice line 1197: Failed to Parse "Ritterstiefel der Ausdauer": [7458:18:0:0:0:0:187:1035573318] (deDE) colorToolTip() used
Verstärkt (+32 Rüstung)
  Warning line 934: preg_match() [function.preg-match]: Empty regular expression
  Warning line 934: preg_match() [function.preg-match]: Empty regular expression
  Roster Notice line 1197: Failed to Parse "Beständige Beinplatten des Adlers": [15596:18:0:0:0:0:869:-1757344628] (deDE) colorToolTip() used
Verstärkt (+32 Rüstung)
  Notice line 1341: Undefined variable: armor_set
  Notice line 1342: Undefined variable: armor_set
  Notice line 294: Undefined index: roter


Code: Select all
  Roster Notice line 1197: Failed to Parse "Schwarzschusspfeil": [28056:0:0:0:0:0:0:0] (deDE) colorToolTip() used
Verursacht 32 zusätzlichen Schaden pro Sekunde.
  Warning line 934: preg_match() [function.preg-match]: Empty regular expression


Code: Select all
  Roster Notice line 1197: Failed to Parse "Schneidenpfeil": [3030:0:0:0:0:0:0:0] (deDE) colorToolTip() used
Verursacht 7,5 zusätzlichen Schaden pro Sekunde.
  Warning line 934: preg_match() [function.preg-match]: Empty regular expression


Code: Select all
  Roster Notice line 1197: Failed to Parse "Bardenhose des Gorillas": [6553:16:0:0:0:0:928:1097283496] (deDE) colorToolTip() used
Verstärkt (+16 Rüstung)


Code: Select all
  Roster Notice line 1197: Failed to Parse "Durchschlagskräftige Schrotkugel": [28060:0:0:0:0:0:0:0] (deDE) colorToolTip() used
Verursacht 22 zusätzlichen Schaden pro Sekunde.
  Warning line 934: preg_match() [function.preg-match]: Empty regular expression
  Warning line 934: preg_match() [function.preg-match]: Empty regular expression
  Notice line 220: Undefined index: WeaponSlot


Code: Select all
  Roster Notice line 1197: Failed to Parse "Derwischstiefel des Falken": [6601:17:0:0:0:0:250:707021626] (deDE) colorToolTip() used
Verstärkt (+24 Rüstung)
  Roster Notice line 1197: Failed to Parse "Grünsteinreif der Regeneration": [11997:0:0:0:0:0:2112:-1487233498] (deDE) colorToolTip() used
Alle 5 Sek. 2 Gesundheit


Code: Select all
  Roster Notice line 1197: Failed to Parse "Gehärtetes Eisenkurzschwert": [3849:0:0:0:0:0:0:1952763033] (deDE) colorToolTip() used
Sofort wirkendes Gift (6 Min.)
  Notice line 220: Undefined index: WeaponSlot
  Roster Notice line 1197: Failed to Parse "Kreuzdolch des Bären": [2819:0:0:0:0:0:1185:605725502] (deDE) colorToolTip() used
Sofort wirkendes Gift (5 Min.)
  Roster Notice line 1197: Failed to Parse "Robustes Geschoss": [3033:0:0:0:0:0:0:0] (deDE) colorToolTip() used
Verursacht 7.5 zusätzlichen Schaden pro Sekunde.
Last edited by rouven on Sun Sep 02, 2007 10:57 am, edited 1 time in total.
User avatar
rouven
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 93
Joined: Fri Jan 12, 2007 4:39 am
Location: Hamburg, Germany

Re: svn[1268] php error and item parsing

Postby tuigii » Mon Aug 27, 2007 5:48 pm

Code: Select all
lib/item.php
  Roster Notice line 1197: Failed to Parse "Potion de respiration aquatique": [25539:0:0:0:0:0:0:1927420490] (frFR) colorToolTip() used
3 charges
  Notice line 220: Undefined index: WeaponSlot
  Notice line 220: Undefined index: WeaponSlot
  Roster Notice line 1197: Failed to Parse "Bouclier en écailles de dragon du soldat": [25085:0:0:0:0:0:-43:-2106327008] (frFR) colorToolTip() used
Bloquer : 86
  Roster Notice line 1197: Failed to Parse "Empreinte de Gordawg": [24475:0:0:0:0:0:0:340480722] (frFR) colorToolTip() used
 
  Notice line 220: Undefined index: WeaponSlot
  Roster Notice line 1197: Failed to Parse "Palefroi bai rapide": [18777:0:0:0:0:0:0:0] (frFR) colorToolTip() used
Races : Humain, Nain, Elfe de la nuit, Gnome, Draeneï


Yup, have these also.

The "bloquer : 86" issue :
Frfr file : change
Code: Select all
$lang['tooltip_preg_block']='/Bloquer :) (\d+)/';  // text for shield blocking values 

to
Code: Select all
$lang['tooltip_preg_armor']='/Bloquer.+ (\d+)/'//// text for shield blocking values 

(or add a tooltip_preg_armor2 type to handle this case - if multipe formats exists - and '/Bloquer :) (\d+)/' is used already with other items.)

The "WeaponSlot" issue:
File /lib/item/php :
Function : function _getWeapon()
Instead of
Code: Select all
        else
        {
            
$html $this->attributes['WeaponSlot'] . '<br />'

}
Shouldn't it be
Code: Select all
        elseif( isset($this->attributes['WeaponSlot']) )
        {
            
$html $this->attributes['WeaponSlot'] . '<br />';
        }        } 


At least, $this->attributes['WeaponSlot'] will be getting used if really set... this seems more logic to me, instead of defaulting to this assumption.


Btw: I finally start to understand the debugging facility that's being used to filter out non-handled tool-tip info.
Well done !!

MOD EDIT: Disabled smiles
Last edited by tuigii on Fri Aug 31, 2007 5:17 am, edited 2 times in total.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France

Re: svn[1268] php error and item parsing

Postby bosco » Fri Aug 31, 2007 5:17 am

Hi,

your solution is correct. I attach my corrected file with a comment when your fix has been done.
Attachments
item.zip
corrected lib/item.php for WeaponSlot parsing bug.
(9.36 KiB) Downloaded 303 times
bosco
WR.net Apprentice
WR.net Apprentice
 
Posts: 26
Joined: Mon Jan 15, 2007 12:24 pm

svn[1268] php error and item parsing

Postby ds » Sun Sep 02, 2007 10:56 am

All this topic should be Fixed in SVN: 1294
Image
ds
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 297
Joined: Sat Jul 08, 2006 9:58 am


Return to Archived

Who is online

Users browsing this forum: No registered users and 1 guest

cron