Nôrrec wrote:I have a porblem with looty and the new WoW Patch.

I've updated my Wowroster 1.7.1 to 1.7.2 and uploaded the guildbank data
now looty is not showing the items any longer. It's just telling an error:

Warning: Invalid argument supplied for foreach() in /usr/export/www/vhosts/funnetwork/hosting/calistoo/looty/index.php on line 476


check: http://calistoo.ca.funpic.de/e107_plugi ... wrap.php?3
and http://calistoo.ca.funpic.de/yroster/ for the roster itself

happens to me as well!! someone help pls!

Yeah just like wow addons many things have broken due to the 2.0 patch blizzard released. We devs are relying on all the addon developers of roster to rebuild there addons to be complaint with roster 1.7.2, but since there was a major change in character and guild profiler it is taking some time to get this version fully fixed. As soon as roster is a release version im sure you all will see more and more addons being fixed and created.

when will it be ready.. i know devs hate that question..but.....when

or has a fix already been made? i havent checked around much

thanx

plz someone fix it

1.7.2 released.
I'm still looking for a working Looty version but don't have enough skills in php to fix it myself

Nôrrec wrote:1.7.2 released.
I'm still looking for a working Looty version but don't have enough skills in php to fix it myself

lol same.... H E L P

It took a little bit of hunting down, but the fix seems to be pretty simple.

On line 226 of index.php you'll see the following piece of code:

Code: Select all


$item['color']          = preg_replace('/^ff/', '#', $item['item_color']);
 

Changing it to the following fixes this problem for me:

Code: Select all

if (strlen($item['color'] == 8)) {
        $item['color'] = preg_replace('/^ff/', '#', $item['item_color']);
} else {
        $item['color'] = preg_replace('/^/', '#', $item['item_color']);
}

 

Hope that helps.

I've noticed that it doesn't seem to work when sorting by item class. I'll see if I can work that out too.

-trell

Ok, and a fix to get selection by item class working.

In index.php at line 164 you should see the following code:

Code: Select all

if ($itemclass) {
        $tmpcolor = 'ff' . preg_replace('/^#/', '', $itemclass);
        $wheres[] = "item_color = '$tmpcolor'";
        }
 

Replace that with the following:

Code: Select all

if ($itemclass) {
        $tmpcolor = preg_replace('/^#/', '', $itemclass);
        $wheres[] = "item_color = '$tmpcolor' or item_color = 'ff$tmpcolor'";
        }
 

And you should be all ok.

-trell

Thanks champ

And if you are still having problems with slashes appearing in the tooltips:

At about line 256 of index.php (it might be different because I've now made a few customisations in the version of looty I'm working on) you'll see a line that looks like:

Code: Select all


$item['tooltip']        = htmlspecialchars(trim($item['item_tooltip']));
 

If you change that to the following, you should lose the extra slashes:

Code: Select all


$item['tooltip']        = htmlspecialchars(stripslashes(trim($item['item_tooltip'])));
 

Hope that helps.

-trell

Hi.

Apologies for the lack of updates: I left my old guild (Citizens of Azeroth) way back in Christmas 2005 (sniff... a sad day, after 7 months as guild master, brings a tear to my eye even now), and didn't really have a chance to use Looty myself to test it and update it etc.

Thanks very much to trell for posting fixes - and honestly credit to you for being able to figure out what was causing the problem in that uncommented mess of code.

Hopefully his fixes should be merged into Looty now properly, along with a couple of other minor things. I am still not in a position to do much work on Looty (read: not playing WoW; not in an active guild with a bank when I am playing; don't have Roster installed anymore), but feel free to get in touch anyway if there's something broken / you'd like added / you're lonely - see my profile for contact details. (Shitloads of them! Whatever happened to the good old days of just email and IRC?) Note: please don't expect any quick replies.

A (slightly less impressive than previous) demo version of Looty can be seen here:

- http://pgl.yoyo.org/wow/looty/

and the latest version is stored here:

- http://pgl.yoyo.org/wow/looty/files/looty-latest.zip (just a symlink to the most recent zip file)
- http://pgl.yoyo.org/wow/looty/files/looty-1.1.zip (... which is this file right here, at the time of writing)

Please see the readme.txt for the changelog and general information:

- http://pgl.yoyo.org/wow/looty/files/readme.txt

cheers,

- Fin

Oh, yeah, one thing: as I don't have Roster installed (and no test characters with inventories I can use for testing publically), would someone be so kind as to send me a dump of their players and items tables from Roster? While I've tested the changes made with the data I had, it would be nice to check with something a bit more recent than 6 months ago.

Thanks in advance for any help with this.

cheers,

- Fin

Thanks for the updates.. I'm on a break from WoW myself and havent logged on for a few months.

trell wrote:Sorry for the delay in getting back to you all. The expansion has been distracting me.

If you are using looty 1.1 and are suffering from the 'Invalid argument supplied for foreach()' on line 485 error then this is the fix for you.

It would appear that the logic is inverted in a statement earlier in the code. So to fix this edit line 230.

It should currently look like:

Code: Select all


$item['color']        = preg_replace((strlen($item['color']) == 8 ? '/^/' : '/^ff/'), '#', $item['item_color']);
 

Change that line to look like:

Code: Select all


$item['color']      = preg_replace((strlen($item['item_color']) == 8 ? '/^ff/' : '/^/'), '#', $item['item_color']);
 

I hope that helps.

-trell

i cant get any items to show up, it says i have 51 items. But none shows. my rosterbank works just fine, showing everything. Any ideas (and yes i aint the pc handyman ^^)

[url=http://emberguild.com/looty/]Ember's Looty
[/url]

Please help... I can't seem to get it to work. The configuration file is configured correctly, as far as I can tell.