Faction problem - The Sha'tar

List faction reputation for members

Moderator: ds

Faction problem - The Sha'tar

Postby Corbism » Thu Apr 26, 2007 3:21 pm

Nice work on the updates to Reputation.

Once problem though. The Sha'tar faction isn't populating with any members data. The previous version of Reputation populated this information (version by Cybrey).

Any ideas?
User avatar
Corbism
WR.net Apprentice
WR.net Apprentice
 
Posts: 51
Joined: Fri Sep 29, 2006 10:48 pm
Location: Seattle, WA

Faction problem - The Sha'tar

Postby bbj911 » Thu Apr 26, 2007 4:47 pm

Its happening on any faction with a ' in the name

Code: Select all
SELECT m.name member, r.faction, r.name fct_name, curr_rep AS value, curr_rep, max_rep, r.standing FROM `roster_reputation` r, roster_members m WHERE r.member_id = m.member_id AND r.name='The Sha\\\'tar' ORDER BY max_rep desc, r.standing DESC, curr_rep DESC


Its overescaped.

remove the wowdb->escape call
Last edited by bbj911 on Thu Apr 26, 2007 6:25 pm, edited 1 time in total.
User avatar
bbj911
WR.net Apprentice
WR.net Apprentice
 
Posts: 61
Joined: Mon Oct 23, 2006 6:47 pm

Re: Faction problem - The Sha'tar

Postby Zefi » Fri Apr 27, 2007 5:19 pm

Same problem with French faction like "L'oeil pourpre" or "L'Aldor" :(
Zefi
WR.net Apprentice
WR.net Apprentice
 
Posts: 5
Joined: Mon Nov 06, 2006 8:26 pm

Faction problem - The Sha'tar

Postby sturmy » Fri Apr 27, 2007 8:02 pm

removing the wowdb->escape did fix it, including for french locale.

Good tip bbj!
sturmy
WR.net Expert
WR.net Expert
 
Posts: 160
Joined: Wed Aug 16, 2006 9:07 pm

Re: Faction problem - The Sha'tar

Postby Corbism » Fri Apr 27, 2007 11:14 pm

Is this the line you are talking about in the "membersRep.php" file as follows:

Code: Select all
    if( (isset($_REQUEST['factionfilter'])) && (($_REQUEST['factionfilter']) != 'All') )
        $query .= " AND r.name='".$wowdb->escape($_REQUEST['factionfilter'])."'";


I am not sure exactly what to remove here.
User avatar
Corbism
WR.net Apprentice
WR.net Apprentice
 
Posts: 51
Joined: Fri Sep 29, 2006 10:48 pm
Location: Seattle, WA

Re: Faction problem - The Sha'tar

Postby bbj911 » Sat Apr 28, 2007 5:16 am

change this line
Code: Select all
    if( (isset($_REQUEST['factionfilter'])) && (($_REQUEST['factionfilter']) != 'All') )
        $query .= " AND r.name='".$wowdb->escape($_REQUEST['factionfilter'])."'";

to
Code: Select all
    if( (isset($_REQUEST['factionfilter'])) && (($_REQUEST['factionfilter']) != 'All') )
        $query .= " AND r.name='".$_REQUEST['factionfilter']."'";
User avatar
bbj911
WR.net Apprentice
WR.net Apprentice
 
Posts: 61
Joined: Mon Oct 23, 2006 6:47 pm

Faction problem - The Sha'tar

Postby tuigii » Mon May 28, 2007 3:58 pm

Yeah, that did it for a French roster !!

Thanks.
User avatar
tuigii
WR.net Master
WR.net Master
 
Posts: 891
Joined: Wed Dec 27, 2006 12:57 pm
Location: Somewhere in the South Ouest of France


Return to Reputation

Who is online

Users browsing this forum: No registered users and 0 guests

cron