I've been seeing a few cases here and there about capitalization mismatching between the files we have under img/interface/icons/ and the files that are being called from the char.php view.

One of my members reported it fixing itself after he uploaded the method CharacterProfiler (as opposed to the Armory sync that I kick off from time to time)

An example member with the graphic problem is here:
Sarlack

The image linked is here:
Broken
Spelled incorrectly as:
INV_Mace_1h_Stratholme_D_01.jpg

The correct spelling is:
INV_Mace_1H_Stratholme_D_01.jpg

(Note the H in 1H)

-Stigg

this is only a problem on linux servers because thay are case sensative where as windows is not lol

This will be fixed in Roster 1.8
On import, roster will convert all interface image names to lower case and replace spaces with underscores

Unfortunately, this means everyone will need to re-download the image pack

zanix wrote:This will be fixed in Roster 1.8
On import, roster will convert all interface image names to lower case and replace spaces with underscores

Unfortunately, this means everyone will need to re-download the image pack

Wooooo! I've been having this issue for awhile Any timeline for this fix or a temporary one I can put in?

Not really, this requires quite a massive change in Roster
There are many, many places that need to be changed to handle the icons this way

zanix wrote:Not really, this requires quite a massive change in Roster
There are many, many places that need to be changed to handle the icons this way

Ah can't wait to see 1.8 then.

fewyn wrote:

zanix wrote:This will be fixed in Roster 1.8
On import, roster will convert all interface image names to lower case and replace spaces with underscores

Unfortunately, this means everyone will need to re-download the image pack

Wooooo! I've been having this issue for awhile Any timeline for this fix or a temporary one I can put in?

I actually noted this as a bug in the original ArmorySynch post. In the file functions.general.php there is a function called getItemIcon. Unfortunately the fixes need to be done one at a time. If you can post the fix, I'll add it to that file.

lib/wowdb.php will convert each icon during the character import process
Each field that has an icon will pass through a function

Code: Select all

function fix_icon($icon_name)
{
    return strtolower(str_replace(' ','_',$icon_name));
} 

Example of use in wowdb.php

Code: Select all

    /**
     * Formats item data to be inserted into the db
     *
     * @param array $item_data
     * @param int $memberId
     * @param string $parent
     * @param string $slot_name
     * @return array
     */
    function make_item( $item_data, $memberId, $parent, $slot_name )
    {
        $item = array();
        $item['member_id'] = $memberId;
        $item['item_name'] = $item_data['Name'];
        $item['item_parent'] = $parent;
        $item['item_slot'] = $slot_name;
        $item['item_color'] = $item_data['Color'];
        $item['item_id'] = $item_data['Item'];
        $item['item_texture'] = $this->fix_icon($item_data['Icon']);

        if( isset( $item_data['Quantity'] ) )
            $item['item_quantity'] = $item_data['Quantity'];
        else
            $item['item_quantity'] = 1;

        if( !empty($item_data['Tooltip']) )
            $item['item_tooltip'] = $this->tooltip( $item_data['Tooltip'] );
        else
            $item['item_tooltip'] = $item_data['Name'];

        return $item;
    }