SigGen link in SigGen Config is displayed wrong

by **secretone** » Sat Mar 17, 2007 11:55 am

Hi,

Just noticed that the link displayed in SigGen Config preview is wrong

See below.

As I am not hot on php and do not want to mess things up could you tell me where to fix this or supply a fix.

Many thanks for a great addon to a great roster.

André

by **tuigii** » Sat Mar 17, 2007 11:17 pm

Somehow, between 'roster' and 'addonns' the slash '/' is missing.

I'm pretty sure that the software couldn't 'just forget about it'.

Double check all your path setting in the (just a couple of) Config settings fields.

In here : http://knightsofold.eu/roster/addons/siggen/sig/... I have ound a (lvl 60 ;-) ) "Secretone.png" image file.....

http://knightsofold.eu/roster/addons/si ... retone.png =

by **suliman** » Sun Mar 18, 2007 12:30 am

Same issue, may be related to my other problem...
0.2.3 worked great...

Upgraded to 0.2.4 from 0.2.3 (dropped table, wipe dir, recopy new 0.2.4, etc.)

My roster is @
www.sillyhoodguild.com/roster

My toon example...

Code: Select all: http://www.sillyhoodguild.com/roster/char.php?name=Suliman&server=Garona

As you can see, the Avatar is not displaying correctly.
*EDIT (Never mind, found the fix for this one...)

HOWEVER, the preview while I'm in the siggen config shows correctly, BUT the "Link to preview images" is farked...
it gives me:

Code: Select all: http://www.sillyhoodguild.com/sillyhood/rosteraddons/siggen/ava.php?member=Suliman

Which of course does not work.

Thoughts?

by **secretone** » Sun Mar 18, 2007 6:38 pm

Hi,

The images are all there being created correctly and I use them in this
forum as my avatar and signature, so no problem there.

It is just the text display of the link in siggen config that is not correct.

I have checked all the paths and URLs they are all correct, the only
suspect one is the main Roster URL which is shown as /roster
I can not get a / on the end of it. If you change it to roster/ then
it does not work at all and screws up the roster.

by **zanix** » Mon Mar 19, 2007 1:20 pm

Edit templates/sc_nametest.tpl

Find

Code: Select all: : '[ '.ROSTER_URL.'addons/siggen/'.($config_name == 'signature' ? 'sig' : 'ava').'.php?member='.urlencode(utf8_decode($name_test)).' ]'));

Replace with

Code: Select all: : '[ '.ROSTER_URL.'/addons/siggen/'.($config_name == 'signature' ? 'sig' : 'ava').'.php?member='.urlencode(utf8_decode($name_test)).' ]'));

by **secretone** » Wed Mar 28, 2007 10:48 pm

Zanix,

You are a star :thumright:

Thanks very much

by **knarf** » Mon Jun 11, 2007 9:05 pm

The fix is not complete as ava.php is still called av.php:

Code: Select all: diff -ur siggen.orig/templates/sc_nametest.tpl ./templates/sc_nametest.tpl --- siggen.orig/templates/sc_nametest.tpl Fri Mar 9 03:55:04 2007 +++ ./templates/sc_nametest.tpl Mon Jun 11 13:40:23 2007 @@ -51,7 +51,7 @@ $functions->setMessage('Link to preview image:<br /> '.(defined('BASEDIR') ? '[ '.getlink('&file=addon&roster_addon_name=siggen&mode='.$config_name.'&member='.urlencode(utf8_decode($name_test)),false,true).' ]' - : '[ '.ROSTER_URL.'addons/siggen/'.($config_name == 'signature' ? 'sig' : 'ava').'.php?member='.urlencode(utf8_decode($name_test)).' ]')); + : '[ '.ROSTER_URL.'/addons/siggen/'.($config_name == 'signature' ? 'sig' : 'av').'.php?member='.urlencode(utf8_decode($name_test)).' ]')); } ?>

Knarf

P.S.: Why does PRE work in the preview and when displaying not?

by **zanix** » Mon Jun 11, 2007 10:40 pm

LoL
I'm being plagued by typos...