Need to enter the correct EnchantID's and GemIDs. If you have Debugging on for the Mod it should report the ID's for you. Then you just need to add them to the WoW_IDs.php file and you'll be set. Also, sharing the ID's to this thread would be great. I'll add your finding to the next Revision of the WoW_IDs.php file.

ds001

I wanted to ask you, I noticed that you had to tweak with the settings.php file to get things to work for your mod. Im wondering, when you have your motd set to image mode in settings, does it not diplay the gmotd.png file for you? I think the settings.php modification may of had something to do with it. If this doesn't seem to be an issue for you, let me know either way, so i can look elsewhere. Its probably me being careless again and not reverting back when i thought it did from a undo. Arg

Thank a bunch.

[EDIT]
Adding to post,

Ok, so i found these

Code: Select all

'2968' => array
(
'name' => 'Thick Amber',
'txt'  => '+4 Defense Rating',
'img'  => 'INV_Misc_Gem_Topaz_03',
),
'2744' => array
(
'name' => 'Dazzling Talasite',
'txt'  => '+4 Intellect and +2 Mana every 5 seconds',
'img'  => 'INV_Jewelcrafting_Talasite_03',
),
'2701' => array
(
'name' => 'Lustrous Azure Moonstone',
'txt'  => '+2 Mana every 5 seconds',
'img'  => 'INV_Misc_Gem_AzureDraenite_02',
),


However, there seems to be a new issue.

Goto this link again
http://www.nomad-legacy.net/WoWRosterDF ... rmoon.html

And look at the Primal Mooncloth Belt, waist item.

The +2 Mana every 5 seconds entry, is now clashing with a gem that has two stats. It thinks it is another socket so it adds the image next to it. I cannot remember if it does this in game or not?

@DiscoWay

The only change to Settings.php by this Mod is the inclusion of WoW_IDs.php.

But, I think the problem is my mistake in WoW_IDs.php I had extra lines after the closing php tag ?> this I sure is causing the header information to break. Download Revision 3 of WoW_IDs.php or just delete the extra lines after the closing php Tag.

@DiscoWay again (edit)

Yeah.. I need to change the logic of the parser for a more line by line replacement rather then a blind global change. I was trying to make it fast but as we can see I need to make it more of a line by line change. I got a guild run soon but after i'm done with that I'll make the changes and post the new changes. Thanks for the report

Ds001 i get ENCHANT ID and GEMS ID .. but how i get the other data for gems ?

(i edited my last post with some enchants and gems that have my members guild )

ds001 wrote:@Zanix: Changed this already for v1.1

I'm sorry ds001, but you did not. You only retrieve the image suffix from the roster config, but not the image folder location, you still assume everyone has them in img/ while some people might have them in other locations (heck, even another server would be possible I think). If you would get the image url from the roster config than I also think this mod would work without changes in DragonFly

Yet another =)

Code: Select all

'2705' => array //corrected
(
'name' => 'Luminous Flame Spessarite',
'txt'  => '+7 Healing Spells and +3 Intellect',
'img'  => 'INV_Misc_Gem_FlameSpessarite_02',
),

[EDIT Addition]


(Gems)

Additions

Code: Select all

'2730' => array //corrected
(
'name' => 'Subtle Living Ruby',
'txt'  => '+8 Dodge Rating',
'img'  => 'INV_Jewelcrafting_LivingRuby_03',
),
'2737' => array //corrected
(
'name' => 'Thick Dawnstone',
'txt'  => '+8 Defense Rating',
'img'  => 'INV_Jewelcrafting_Dawnstone_03',
),
'2693' => array //corrected
(
'name' => 'Delicate Blood Garnet',
'txt'  => '+6 Agility',
'img'  => 'INV_Misc_Gem_BloodGem_02',
),
'2969' => array //corrected
(
'name' => 'Swift Windfire Diamond',
'txt'  => '+20 Attack Power and Minor Run Speed Increase',
'img'  => 'INV_Misc_Gem_Diamond_07',
),


(Enchants)

Additions

Code: Select all

'2666' => '+30 Intellect',
'2996' => '+13 Critical Strike Rating',


Corrections

Code: Select all

'2503' => '+5 Defense',


Another enchant:

Code: Select all

'3002' => '+22 Spell Power and +14 Spell Hit Rating',


Diska wrote:

ds001 wrote:@Zanix: Changed this already for v1.1

I'm sorry ds001, but you did not. You only retrieve the image suffix from the roster config, but not the image folder location, you still assume everyone has them in img/ while some people might have them in other locations (heck, even another server would be possible I think). If you would get the image url from the roster config than I also think this mod would work without changes in DragonFly

Boy I feel like a noob. Guess I should actually READ the post and not assume the content. Sorry 'bout that. *blushes*

I will add that for the next version that should be done tonight I hope. Rewriting most of it as it was not the best method after seeing the problems you guys found.

Here is Rev 4 of WoW_IDs.php.

Added many thanks to Subxero and DiscoWay!

Add to Gems

Code: Select all

'2765' => array
(
'name' => 'Stormy Star of Elune',
'txt'  => '+10 Spell Penetration',
'img'  => 'INV_Jewelcrafting_StarOfElune_03',
),
'2727' => array
(
'name' => 'Teardrop Living Ruby',
'txt'  => '+18 Healing',
'img'  => 'INV_Jewelcrafting_LivingRuby_03',
),
'2741' => array
(
'name' => 'Royal Nightseye',
'txt'  => '+9 Healing Spells and +2 Mana every 5 seconds',
'img'  => 'INV_Jewelcrafting_Nightseye_03',
),
'2733' => array
(
'name' => 'Lustrous Star of Elune',
'txt'  => '+3 Mana every 5 seconds',
'img'  => 'INV_Jewelcrafting_StarOfElune_03',
),

Add to Enchants

Code: Select all

'2937' => '+20 Spell Damage',

Scaled Greaves of Patience is not showing gems/enchants correctly..

This user has the item
http://www.blacktemplars.org/index.php? ... er=Kilrogg

zanix wrote:Instead of hardcoding the image url, use Roster's variables to write it

To get the icons to show up in wowrosterdf I edited line 497 commonfunctions.lib.php from this

Code: Select all

$parsedToolTip = str_replace($gem_ids[$id]['txt'], '<img width="16px" height="16px" src="img/Interface/Icons/'.$gem_ids[$id]['img'].'.'.$roster_conf['img_suffix'].'"><span style="color:#00ff00;">  '.$gem_ids[$id]['txt'].'</span>', $parsedToolTip);

to this

Code: Select all

$parsedToolTip = str_replace($gem_ids[$id]['txt'], '<img width="16px" height="16px" src="'.$roster_conf['interface_url'].'Interface/Icons/'.$gem_ids[$id]['img'].'.'.$roster_conf['img_suffix'].'"><span style="color:#00ff00;">  '.$gem_ids[$id]['txt'].'</span>', $parsedToolTip);

I assume making this change in the stand alone version will work as well.

robojerk wrote:Scaled Greaves of Patience is not showing gems/enchants correctly..

This user has the item
http://www.blacktemplars.org/index.php? ... er=Kilrogg

I am not seeing the debugging information so that means the ItemID was not passed to the tooltip parser. I would guess for whatever reason CP did not capture the ItemID string. Recapture the data and reupload and I bet it will work.

Getting all gems from http://www.wowhead.com/?items=-2

new one (without corrected id !!)

Code: Select all

'30565' => array
(
'name' => 'Assassin\'s Fire Opal',
'txt'  => 'Critical Rating +6 and Dodge Rating +5',
'img'  => 'INV_Jewelcrafting_NobleTopaz_03',
),

Correct tooltip and twice faction (without corrected id !!)

Code: Select all

'27786' => array  //horde
(
'name' => 'Barbed Deep Peridot',
'txt'  => '+3 Stamina, +4 Critical Strike Rating',
'img'  => 'INV_Misc_Gem_DeepPeridot_01',
),
'27809' => array //alliance
(
'name' => 'Barbed Deep Peridot',
'txt'  => '+3 Stamina, +4 Critical Strike Rating',
'img'  => 'INV_Misc_Gem_DeepPeridot_01',
),

added (without corrected id !!)

Code: Select all

'30571' => array
(
'name' => 'Don Rodrigo\'s Heart',
'txt'  => '+8 Strength',
'img'  => 'INV_Misc_Gem_Ruby_01',
),

Correct tooltip (only one with correct id)

Code: Select all

'27820' => array //alliance
(
'name' => 'Notched Deep Peridot',
'txt'  => '+3 Stamina, +4 Spell Critical Strike Rating',
'img'  => 'INV_Misc_Gem_DeepPeridot_03',
),
'2898' => array //horde corrected Subxero
(
'name' => 'Notched Deep Peridot',
'txt'  => '+3 Stamina, +4 Spell Critical Strike Rating',
'img'  => 'INV_Misc_Gem_DeepPeridot_03',
),

A correct id

Code: Select all

'2943' => array
(
'name' => 'Mighty Blood Garnet',
'txt'  => '+14 Attack Power',
'img'  => 'INV_Misc_Gem_Bloodstone_02',
),

And yes like robojerk say 2756 is >> 2765

Enchants:
Addition

Code: Select all

'2997' => '+15 Critical Strike Rating and +20 Attack Power',

Correction

Code: Select all

'3001' => '+35 Healing and 7 Mana Per 5 sec.',

Because some people get these errors ?

Failed to match enchant_txt from db
enchant txt: +9 Stamina
on tooltip show: Stamina +9

And others like HP +100 / +100 HP

+20 Fire Spell Damage / +20 Fire Damage
+20 Shadow Spell Damage / +20 Shadow Damage

etc..

inversed order 8(