Known bugs

A shopping addon for Roster

Moderator: Hannah

Known bugs

Postby Hannah » Sat Jul 22, 2006 1:25 am

Tolrac wrote:Thank you...

I wait the modified code...
Hi Tolrac!

I´m sry but i tested nearly 3 hours with phpnuke and shopping addon
but ithink the session part in the shopping code won´t work with phpnuke...

I couldn´t get it to work...:(

Sry, maybe a phpnuke crack could have a look at it ?

CU Hannah
User avatar
Hannah
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 142
Joined: Tue Jul 04, 2006 1:41 pm
Location: Germany, Cologne

Re: Known bugs

Postby Tolrac » Tue Jul 25, 2006 4:37 pm

Hi,

There is the french localization for Shopping AddOn:

Code: Select all

$wordings
['frFR']['shopping'] = 'Caddie';
$wordings['frFR']['professionfilter'] = 'Filtrer Métier:';
$wordings['frFR']['itemdescription'] = 'Description de l\'item:';
$wordings['frFR']['whocanmakeit'] = 'Qui peut le faire';
$wordings['frFR']['dnotpopulatelist'] = 'n\'a pas complété la liste ';
$wordings['frFR']['applybutton']= 'Appliquer';
$wordings['frFR']['shoppingbasket'] = 'Voir Caddie / Checkout';
$wordings['frFR']['youhave'] = 'Vous avez';
$wordings['frFR']['inbasket'] = 'item(s) dans votre panier.';
$wordings['frFR']['quantity'] = 'Quantité';
$wordings['frFR']['product'] = 'Produit';
$wordings['frFR']['delete'] = 'Effacer';
$wordings['frFR']['continue'] = 'Continuer Shopping';
$wordings['frFR']['order'] = 'Commande';
$wordings['frFR']['emptybasket'] = 'Votre panier est actuellement vide.';
$wordings['frFR']['error'] = 'Erreur inconnue.';
$wordings['frFR']['maker'] = 'produit à partir';
$wordings['frFR']['sendto'] = 'Livrer à ';
$wordings['frFR']['ordersend'] = 'Commande dans la file d\'attente ! Automatiquement Uploader avec UniUploader!';
 
Last edited by Tolrac on Tue Jul 25, 2006 5:00 pm, edited 1 time in total.
Tolrac
WR.net Apprentice
WR.net Apprentice
 
Posts: 30
Joined: Tue Jul 04, 2006 1:22 pm

Re: Known bugs

Postby Tolrac » Tue Jul 25, 2006 4:38 pm

Hi,

thank you for your work but now i have installed the roster 1.7 phpnuked, and it's working fine.

Thank you.
Tolrac
WR.net Apprentice
WR.net Apprentice
 
Posts: 30
Joined: Tue Jul 04, 2006 1:22 pm

Re: Known bugs

Postby Tolrac » Tue Jul 25, 2006 4:58 pm

how to change this, for integrate to the roster phpnuked 1.7:

Code: Select all

$choiceForm 
'<form action="addon.php" method=GET name=myform>
                <input type="hidden" name="roster_addon_name" value="shopping">
                 <table>
                 <th class="copy">'
.$wordings[$roster_conf['roster_lang']]['professionfilter'].'</th>
                 <td class="copy"><select NAME="proffilter">'
;
 


Thank you for your help
Tolrac
WR.net Apprentice
WR.net Apprentice
 
Posts: 30
Joined: Tue Jul 04, 2006 1:22 pm

Known bugs

Postby Hannah » Tue Jul 25, 2006 5:21 pm

Hi Tolrac!

Thx for the french translation will put it into this night :)

EDIT: Not tonight sry :)

OK, 1.7 phpnuke is easier way ;)
Last edited by Hannah on Wed Jul 26, 2006 1:14 am, edited 1 time in total.
User avatar
Hannah
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 142
Joined: Tue Jul 04, 2006 1:41 pm
Location: Germany, Cologne

Re: Known bugs

Postby Adariel » Sun Aug 06, 2006 10:54 pm

Leatherworking: Hillman's Cloak will not add to the cart - it just shows a blank page.

I don't have a lot of people's profiles uploaded to test with atm, but have noted that Alchemy: Elixir of Ogre's Strength and Strong Troll's Blood Potion have the same issue.

I'm guessing it has to do with the apostrophe - but I have no idea where to change the code to escape it so the PHP doesn't argue with it.
User avatar
Adariel
WR.net Apprentice
WR.net Apprentice
 
Posts: 36
Joined: Tue Jul 25, 2006 9:14 am

Re: Known bugs

Postby Hannah » Sun Aug 06, 2006 11:55 pm

Adariel wrote:Leatherworking: Hillman's Cloak will not add to the cart - it just shows a blank page.

I don't have a lot of people's profiles uploaded to test with atm, but have noted that Alchemy: Elixir of Ogre's Strength and Strong Troll's Blood Potion have the same issue.

I'm guessing it has to do with the apostrophe - but I have no idea where to change the code to escape it so the PHP doesn't argue with it.


Hi Adariel!
Here´s a quick way solution :)

Open functions_cart.php and find line 80:
Code: Select all

$id 
str_replace(""""$id);
 

and add the following line after that
Code: Select all

$id 
escape($id);
 


Also find line 94:
Code: Select all

$_SESSION
["cart"][$item_count][0] = $item["recipe_name"];
 

change it to this:
Code: Select all

$_SESSION
["cart"][$item_count][0] = escape($item["recipe_name"]);
 


At the end of the file before this line:
Code: Select all
//ob_end_flush();
 

add the following part
Code: Select all

         
/** Thx roster devs for this :)
         * Front-end to escape string for safe inserting
         *
         * @param string $string
         * @return string escaped
         */
        
function escape$string )
        {
                if( 
version_comparephpversion(), '4.3.0''>' ) )
                        return 
mysql_real_escape_string$string );
                else
                        return 
mysql_escape_string$string );
        }
 



That´s it...

Give it a try :)

This only happens on english clients cause in german it´s Hillmann-Umhang without the apostrophe...

Test it for me i´ll search the code for any equal problem and thx for your
reply :)

Hannah
User avatar
Hannah
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 142
Joined: Tue Jul 04, 2006 1:41 pm
Location: Germany, Cologne

Known bugs

Postby Adariel » Mon Aug 07, 2006 12:11 am

worked great - thanks for the quick response :)
User avatar
Adariel
WR.net Apprentice
WR.net Apprentice
 
Posts: 36
Joined: Tue Jul 25, 2006 9:14 am

Known bugs

Postby klyd » Thu Sep 14, 2006 6:29 am

I have a set up the addon and it seems to work very well, thanks for all your work in advance.

The little problem/bug I encountered is, when I log in the character which should send the order, click the minimap button and select "View Order" everything's ok. I then pressed "Cancel" because I wasnt at a mailbox at that moment.

Arrived at the Mailbox, the button has gone and a /shopping show only presented me an empty list. But clicking on "Send" transmitted the order properly even though it hasn't appeared in the list anymore.
User avatar
klyd
WR.net Apprentice
WR.net Apprentice
 
Posts: 4
Joined: Mon Aug 21, 2006 5:26 pm
Location: Germany

Known bugs

Postby Hannah » Thu Sep 14, 2006 11:01 am

Hi klyd!

If you type in /shopping after you canceled the "Shopping-Cart-View"
the orders are set to state "deleted" which means they won´t be send...

I´m a bit confused that you say they are send (i know you can clikc send button but it send´s nothing)

Have you checked the mailbox of the person you send the mail (ask your member if he recieved the mail)

I´ll check if the new patch has some new behaviour with the sendmail-function...

CU and thx

Hannah
User avatar
Hannah
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 142
Joined: Tue Jul 04, 2006 1:41 pm
Location: Germany, Cologne

Re: Known bugs

Postby klyd » Thu Sep 14, 2006 2:50 pm

Hannah wrote:Hi klyd!

If you type in /shopping after you canceled the "Shopping-Cart-View"
the orders are set to state "deleted" which means they won´t be send...


How am I then supposed to bring up the window again to be able to send them ?

I´m a bit confused that you say they are send (i know you can clikc send button but it send´s nothing)


Yes, I verified it (sent it to an alt of mine) and pressing the send button after initialy cancelling the window, then typing "/shopping" sends the mail, even though it's not appeared in the list anymore.
User avatar
klyd
WR.net Apprentice
WR.net Apprentice
 
Posts: 4
Joined: Mon Aug 21, 2006 5:26 pm
Location: Germany

Known bugs

Postby Hannah » Thu Sep 14, 2006 6:45 pm

If you open the window at startup just press send, no need first open mailbox...

If you´ve done this go to a mailbox open it and it´ll send the order (saves the order in memory..)

Hope that help´s :)
User avatar
Hannah
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 142
Joined: Tue Jul 04, 2006 1:41 pm
Location: Germany, Cologne

Re: Known bugs

Postby klyd » Fri Sep 15, 2006 1:16 am

Hannah wrote:If you open the window at startup just press send, no need first open mailbox...

If you´ve done this go to a mailbox open it and it´ll send the order (saves the order in memory..)

Hope that help´s :)


Ahhhh.....*rockdrops*
Ok now even me understood it :P Thanks. Maybe it would be better to label the button something like "Queue" or so or else mention this somewhere in the manual. Would make it much clearer from the beginning. But I understand that this great addon is in dev, so isn't really that important ;)

Me and my guild can't wait 'till the bank function is implemented and some kind of feedback regarding the order....

Really...great work you've done :))

EDIT: Just saw the entries still reside in the .lua file. Does it get bigger every time or are old entries deleted sometime ?
Last edited by klyd on Fri Sep 15, 2006 1:18 am, edited 1 time in total.
User avatar
klyd
WR.net Apprentice
WR.net Apprentice
 
Posts: 4
Joined: Mon Aug 21, 2006 5:26 pm
Location: Germany

Known bugs

Postby Hannah » Fri Sep 15, 2006 11:14 am

Old ones will be deleted next time you place a "web order"...

Good point ("Queue") ... next release :)
User avatar
Hannah
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 142
Joined: Tue Jul 04, 2006 1:41 pm
Location: Germany, Cologne

Re: Known bugs

Postby Thorald » Wed Jan 17, 2007 10:37 am

hallo hannah,

ich habe das shopping addon in den wow ordner getan. Als ich mit wow online ging und den addon ordner aufgerufen habe stand neben shopping inkompatibel ! woran liegt das? Als ich über shopping die maus über shopping hatte stand dort nur roster. mehr nicht....
könntest du mir bitte helfen bzw. erklären was ich falsch gemacht habe ?
Last edited by Thorald on Wed Jan 17, 2007 10:40 am, edited 1 time in total.
Thorald
WR.net Apprentice
WR.net Apprentice
 
Posts: 6
Joined: Thu Nov 02, 2006 5:36 am

PreviousNext

Return to Shopping

Who is online

Users browsing this forum: No registered users and 1 guest