I'll do resist calculations first and after maybe we can work on your suggestions

As a first step, I assume that as I was saying, detecting the first "set" keyword would help to avoid counting multiple time the set bonus. That would already be "better" from my point of view.

Then, algorithmically speaking, we'd need to identify the number of pieces at which the + resist bonus is gained. Then identify set pieces (they all have the "set name" that we can cache somewhere), count them with their position & inherent resist bonus. If count < set pieces in store, forget about the set thing. if = or above, then we should start thinking further. Something like comparing current "best resist" item slots with the set items positions. If empty vs set item, take set item, and if we go up to the required set number, we've got a deal. Otherwise, we need to compare the set bonus + conflicting resists with current "best non set".

Well, that's where I was left at in my thinking, since I also started working on this at some point, and got distracted by aliens landing in my garden, or something as important as this (yes, just trying to be funny here, don't start asking me about what the aliens ate that night ;-) ).

Uh ? What the aliens ate that night ?

To detect set items first :

Code: Select all

SELECT DISTINCT SUBSTRING( `item_tooltip`, LOCATE('

',`item_tooltip`)+2, LOCATE('(',`item_tooltip`) - LOCATE('

',`item_tooltip`)-2) AS `set_name`, SUBSTRING( `item_tooltip`, LOCATE('/',`item_tooltip`,LOCATE('(', `item_tooltip`))+1, LOCATE(')',`item_tooltip`) - LOCATE('/',`item_tooltip`,LOCATE('(', `item_tooltip`))-1) AS `pieces_number`  FROM `roster_items` WHERE `item_tooltip` REGEXP '\([0-9]+/[0-9]+\)' AND `member_id` = $member_id

Tomorrow the count of pieces, and parsing of sets bonuses.

quick thought before going to bed (in case you wonder, yes, the aliens left late tonight :-P ), we probably need to be careful as the tooltip will be different if the set item is worn or not (since tooltip In Game displays a different wording whether a bonus is reached when items are worn, or stored in a bag or not complete).

Or are we getting the tooltip contents from alla's web?

Damn. Well, I'll sleep over this and be back tomorrow.

Yep, I have though about this "little" problem. We have several solutions :
- check if the item isn't equiped
- get set bonuses from allakhazam (can be a bit long)
- if the item is equiped and no other set item isn't equipped, we can guess the number of pieces to get the bonus :
8 pieces and 3 bonus levels
=> 3 pieces, 5 pieces, 8 pieces
9 pieces and 4 bonus levels
=> 2 pieces, 4 pieces, 6 pieces, 8 pieces
5 pieces and 2 bonus levels
=> 3 pieces, 5 pieces
etc...
(number of pieces for bonus set = round ( total pieces * rank / number of steps ) )

There are sometimes multiple bonuses when reaching a set "threshold", in which case that trick might not work... I believe T0 or T1 pally is in this case? Otherwise that idea's great.

I vote against alla's. it would introduce delays we shouldn't need for this addon.

Indeed, you're right, there 2 sets bonuses at 5 pieces for T1 pally... (such a shame, i'm a pally )

We can also check in all database for a non equipped piece of this set, and extract the set bonuses.

Then I assume the lesser evil is:
-look for 1 set item not equipped to get the set bonuses & level at which they're gained
-if none is found, then either the resist bonus is last (meaning full set required) and we have a simple solution, or we have to resort calling alla's for help

Kinda tricky for such a simple thing, but as we rely on the tooltips...

BTW Pally myself, but I long forgot when I gained this bonus ;-)

Storing sets and their bonuses in database can save calculation time, and be useful for other addons (I think to ItemSet for example). And each time an user upload CP.lua we can update sets and set bonuses for non equipped items. If it's a new set, and all pieces are equipped and if a set bonus is reached, then the set bonus is for the number of pieces equipped.

any news on it?

Sorry I was really busy

I will try to work this weekend, if I have enough time

Finding a couple of items that are still not showing up for +NR. One is the picture of the Ballistic Bone in the offhand position but is showing up under the totals. The Noxious Shooter +5 NR Wand isn't showing up at all.