[BUG] max.resists + CharacterProfiler 1.6.3

by **knappster** » Thu Sep 28, 2006 6:19 pm

When I update my info with CharacterProfiler v1.6.3 (I didn't ever check with 1.6.2), the empty slots show as having a keyring in them. So whenever I click on a resistance for a character using that version of profiler, it shows keyrings in all of the empty slots. Is there a fix for that? I'm not 100% sure what version of max.resists I am using, but I can probably find out tonight.

by **toldi** » Thu Sep 28, 2006 6:48 pm

Whoa i even have this problem, and i just did debuging it atm.

What i do it:

OPEN maxres.php
Search at Line 19

Code: Select all: $item = item_get( $this->data['member_id'], $item_name ); if( isset($item) and $item != "" ) $output = $item->out(); else

REPLACE TO:

Code: Select all: if ( $item_name != "") { $item = item_get( $this->data['member_id'], $item_name ); if( isset($item) and $item != "" ) $output = $item->out(); } else

I Even have problem on line 597:

Code: Select all: return date($phptimeformat[$roster_lang], $localtime);

I dunno where from the $phptimeformat[$roster_lang] variable, but that is Null, and the Last Updated text not showing correctly, showing nothing

i have replaced to this:

Code: Select all: return date("Y-m-d H:i:s", $localtime);

*EDIT: i added to post my problem, and fixation.

by **PleegWat** » Thu Sep 28, 2006 7:19 pm

$phptimeformat is defined in the localization. It's probably not globaled for the addon call.

* checks

yup. Try $_GLOBALS['phptimeformat'][$roster_lang], that should work.

by **AnthonyB** » Fri Sep 29, 2006 2:22 am

Hmmm.. trying to fix the Last updated time.. replacing

Code: Select all: return date($phptimeformat[$roster_lang], $localtime);

with

Code: Select all: return date($_GLOBALS['phptimeformat'][$roster_lang], $localtime);

didn't work...

by **knappster** » Fri Sep 29, 2006 7:35 am

Pleeg's fix didn't work for me either... but toldi's did.

I also added the line

Code: Select all: $localtimeoffset = -5;

so that it would put my time in CST.

by **Diska** » Fri Sep 29, 2006 2:58 pm

Thanks for reporting the bugs, but I'm afraid the fixes aren't okay.
The correct fixes are as following:

Replace:

Code: Select all: global $img_url; // Added this global variable to use in the image link $item = item_get( $this->data['member_id'], $item_name );

with:

Code: Select all: global $img_url; // Added this global variable to use in the image link if ( $item_name != "" ) $item = item_get( $this->data['member_id'], $item_name );

and at line 596 replace:

Code: Select all: $localtime = mktime($hour+$localtimeoffset,$minute, $second, $month, $day, $year, -1); return date($phptimeformat[$roster_lang], $localtime);

with

Code: Select all: $localtime = mktime($hour+$roster_conf['localtimeoffset'] ,$minute, $second, $month, $day, $year, -1); return date($phptimeformat[$roster_conf['roster_lang']], $localtime);

by **knappster** » Fri Sep 29, 2006 10:07 pm

So the newest version available for download has all of these changes?

by **Diska** » Sat Sep 30, 2006 12:39 am

yes, it does

by **AnthonyB** » Sat Sep 30, 2006 8:50 am

Hi Diska,

While you're fixing and posting, could you make the following change which fixes issues in the current Roster betas where the trigger fails on some platforms:

trigger.php, line 31, replace

Code: Select all: require_once('../lib/item.php');

with

Code: Select all: require_once(ROSTER_LIB.'item.php');

by **Diska** » Sat Sep 30, 2006 4:46 pm

AnthonyB wrote:While you're fixing and posting, could you make the following change which fixes issues in the current Roster betas where the trigger fails on some platforms:

Thanks! Fixed now and incorperated in 3.10

by **Speedtorch** » Sun Oct 01, 2006 6:22 pm

I downloaded MaxResists 3.10 and I get the following error:

Warning: main(ROSTER_LIBitem.php) [function.main]: failed to open stream: No such file or directory in /homepages/24/d174628148/htdocs/_shadowguard/roster/addons/maxres/trigger.php on line 31

Fatal error: main() [function.require]: Failed opening required 'ROSTER_LIBitem.php' (include_path='.:/usr/local/lib/php') in /homepages/24/d174628148/htdocs/_shadowguard/roster/addons/maxres/trigger.php on line 31

So, I changed line 31 back to:

Code: Select all: require_once('../lib/item.php');

And all works fine. So, where is ROSTER_LIB being defined? I don't see it...

by **PleegWat** » Sun Oct 01, 2006 9:31 pm

In settings.php, starting 1.7.1

by **Subxero** » Wed Oct 04, 2006 3:05 am

when can try these 1.7.1 ? arff arfff

by **PleegWat** » Wed Oct 04, 2006 9:47 pm

You can't. It's in one of the last phases of beta testing, and the latest beta has been pushed to beta testers but also to addon developers. I suspect Diska forgot to test on 1.7.0 for this release.

by **Nomad_Wanderer** » Sat Oct 07, 2006 7:00 pm

Pleeg, you just broke this addon for everyone then
If I can't get 1.7.1, why make a change to max resists that requires 1.7.1?

require_once('../lib/item.php');

on line 31
is required in trigger.php to get this addon to work if you are running 1.7.0