Luckygirl wrote:Friend's roster site has the icons showing up with multiple mount icons per character where applicable. I asked him about it and he said he downloaded some extra icons??

http://guildpraetorian.com/roster/

Okay, from my guess, not everyone has updated their profiles. Before the new "fix" for riding, everyone could get training in riding for the different mounts. The "fix" set it where it dosen't matter where you train your riding skill, it just matters that you have A riding skill.
The Praetorian guild roster will need to be updated with vgjunkie's code (see above), to actually work right, and everyone will have to upload their stats again to make things work.

Thankyou for the clarifacation. You guys rock for supporting this support forum!

vgjunkie wrote:

sileed wrote:1. Check for Riding Skill
2. then grab player Race
3. Display "default" icon for riding by Race (Horse for Human, Cat for NE, Ram for Dwarves etc...)

Possibly making it an array:

If Riding Skill exist
Race = Human, icon=horse
Race= NE, icon=Cat
etc..

You coders will work it out, I just make up the ideas

I added local/enUS.php file:

Code: Select all

// Riding Skill Icons-Array
$wordings['enUS']['Riding'] = array(
                'Night Elf'=>'Ability_Mount_WhiteTiger',
                'Human'=>'Ability_Mount_RidingHorse',
                'Dwarf'=>'Ability_Mount_MountainRam',
                'Gnome'=>'Ability_Mount_MechaStrider',
                'Undead'=>'Ability_Mount_Undeadhorse',
                'Troll'=>'Ability_Mount_Raptor',
                'Tauren'=>'Ability_Mount_Kodo_03',
                'Orc'=>'Ability_Mount_BlackDireWolf',
);



Then in memberslist.php (in the "Main Query") add:

Code: Select all

'`players`.`race`, '.

(I put it above  '`players`.`RankName`, '.)


Then! in the function tradeskill_icons below:

Code: Select all

Below the $skill_image variable I added:

if($r_prof['skill_name'] == "Riding")
$skill_image = 'Interface/Icons/'.$wordings[$row['clientLocale']]['Riding'][$row['race']];



It's a good amount of work, and will probably get fixed soon, so depending on how desperate you are to get it working, you can just ignore my madness

Ok now I feel stupid... i changed the files like you said, or at least though that I did, but I don't get any riding icons showing up for the new riding skills of 75 or 150. Are both the last 2 changes made in the memberlist.php, or is the function tradeskill_icons in a different file?

Thanks in advance for your help

vgjunkie wrote:

sileed wrote:1. Check for Riding Skill
2. then grab player Race
3. Display "default" icon for riding by Race (Horse for Human, Cat for NE, Ram for Dwarves etc...)

Possibly making it an array:

If Riding Skill exist
Race = Human, icon=horse
Race= NE, icon=Cat
etc..

You coders will work it out, I just make up the ideas

I added local/enUS.php file:

Code: Select all

// Riding Skill Icons-Array
$wordings['enUS']['Riding'] = array(
                'Night Elf'=>'Ability_Mount_WhiteTiger',
                'Human'=>'Ability_Mount_RidingHorse',
                'Dwarf'=>'Ability_Mount_MountainRam',
                'Gnome'=>'Ability_Mount_MechaStrider',
                'Undead'=>'Ability_Mount_Undeadhorse',
                'Troll'=>'Ability_Mount_Raptor',
                'Tauren'=>'Ability_Mount_Kodo_03',
                'Orc'=>'Ability_Mount_BlackDireWolf',
);



Then in memberslist.php (in the "Main Query") add:

Code: Select all

'`players`.`race`, '.

(I put it above  '`players`.`RankName`, '.)


Then! in the function tradeskill_icons below:

Code: Select all

Below the $skill_image variable I added:

if($r_prof['skill_name'] == "Riding")
$skill_image = 'Interface/Icons/'.$wordings[$row['clientLocale']]['Riding'][$row['race']];



It's a good amount of work, and will probably get fixed soon, so depending on how desperate you are to get it working, you can just ignore my madness

this fix works and my guild members like me again (*phew* almost got lynched when i told the everyone was gonna have the Horse for riding)

of note if you run AltMonitor make sure you do the Memberlist.php changes to altlist.php aswell

This won't work on a german or french roster, will it?

It would be really nice if someone would post a localised version of the fix.

Thank you in advance
Rain

also for a german roster pls! :rabbit2:

ok French and german translations Thank the Siggen Author for this i just used his translations

French frFR.php

Code: Select all

// Riding Skill Icons-Array
$wordings['frFR']['Riding'] = array(
                'Elfe de la nuit'=>'Ability_Mount_WhiteTiger',
                'Humain'=>'Ability_Mount_RidingHorse',
                'Nain'=>'Ability_Mount_MountainRam',
                'Gnome'=>'Ability_Mount_MechaStrider',
                'Mort-Vivant'=>'Ability_Mount_Undeadhorse',
                'Troll'=>'Ability_Mount_Raptor',
                'Tauren'=>'Ability_Mount_Kodo_03',
                'Orc'=>'Ability_Mount_BlackDireWolf',
);

function tradeskill_icons

Code: Select all

if($r_prof['skill_name'] == "Monte")
$skill_image = 'Interface/Icons/'.$wordings[$row['clientLocale']]['Riding'][$row['race']];


German deDE.php

Code: Select all

// Riding Skill Icons-Array
$wordings['deDE']['Riding'] = array(
                'Nachtelf'=>'Ability_Mount_WhiteTiger',
                'Human'=>'Ability_Mount_RidingHorse',
                'Zwerg'=>'Ability_Mount_MountainRam',
                'Gnom'=>'Ability_Mount_MechaStrider',
                'Untoter'=>'Ability_Mount_Undeadhorse',
                'Troll'=>'Ability_Mount_Raptor',
                'Tauren'=>'Ability_Mount_Kodo_03',
                'Orc'=>'Ability_Mount_BlackDireWolf',
);


function tradeskill_icons

Code: Select all

if($r_prof['skill_name'] == "Reiten")
$skill_image = 'Interface/Icons/'.$wordings[$row['clientLocale']]['Riding'][$row['race']];


the

Code: Select all

'`players`.`race`, '.

should work on all due it refeering to the database

wacoede wrote:Thank the Siggen Author for this i just used his translations

You are welcome

Hello all,

I have implemented this fix but I have changed a little bit the code so that you don't have a specific language to use in the if condition. I have also added the special cases of Warlock and Paladin.

Here is what I have done for french:
- In frFR.php (just after the line

Code: Select all

$wordings['frFR']['PvPRankNone']=... 

) add the line:

Code: Select all

$wordings['frFR']['Riding'] = 'Monte'; 

- in frFR.php, add the array:

Code: Select all

// Riding Skill Icons-Array
$wordings['frFR']['riding_iconArray'] = array(
                'Elfe de la nuit'=>'Ability_Mount_WhiteTiger',
                'Humain'=>'Ability_Mount_RidingHorse',
                'Nain'=>'Ability_Mount_MountainRam',
                'Gnome'=>'Ability_Mount_MechaStrider',
                'Mort-Vivant'=>'Ability_Mount_Undeadhorse',
                'Troll'=>'Ability_Mount_Raptor',
                'Tauren'=>'Ability_Mount_Kodo_03',
                'Orc'=>'Ability_Mount_BlackDireWolf',
                'Paladin'=>'Ability_Mount_Dreadsteed',
                'Démoniste'=>'Ability_Mount_NightmareHorse'
); 

- in memberlist.php in the main query, just before

Code: Select all

'`players`.`RankName`, '. 

, add the line:

Code: Select all

'`players`.`race`, '. 

- in memberlist.php, in the function tradeskill_icons, change the line:

Code: Select all

$skill_image = 'Interface/Icons/'.$wordings[$row['clientLocale']]['ts_iconArray'][$r_prof['skill_name']]; 

with:

Code: Select all

        if($r_prof['skill_name'] == $wordings[$row['clientLocale']]['Riding'])
            if($row['class']==$wordings[$row['clientLocale']]['Paladin'] || $row['class']==$wordings[$row['clientLocale']]['Warlock'])
                $skill_image = 'Interface/Icons/'.$wordings[$row['clientLocale']]['riding_iconArray'][$row['class']];
            else
                $skill_image = 'Interface/Icons/'.$wordings[$row['clientLocale']]['riding_iconArray'][$row['race']];
        else
            $skill_image = 'Interface/Icons/'.$wordings[$row['clientLocale']]['ts_iconArray'][$r_prof['skill_name']]; 

Then if you want it for us or de or whatever language, only the localization file needs to be changed.

For enUS:
- In enUS.php (just after the line

Code: Select all

$wordings['enUS']['PvPRankNone']=... 

) add the line:

Code: Select all

$wordings['enUS']['Riding'] = 'Riding'; 

- in enUS.php, add the array:

Code: Select all

// Riding Skill Icons-Array
$wordings['enUS']['riding_iconArray'] = array(
                'Night Elf'=>'Ability_Mount_WhiteTiger',
                'Human'=>'Ability_Mount_RidingHorse',
                'Dwarf'=>'Ability_Mount_MountainRam',
                'Gnome'=>'Ability_Mount_MechaStrider',
                'Undead'=>'Ability_Mount_Undeadhorse',
                'Troll'=>'Ability_Mount_Raptor',
                'Tauren'=>'Ability_Mount_Kodo_03',
                'Orc'=>'Ability_Mount_BlackDireWolf',
                'Paladin'=>'Ability_Mount_Dreadsteed',
                'Warlock'=>'Ability_Mount_NightmareHorse'
); 

For deDE:
- In deDE.php (just after the line

Code: Select all

$wordings['deDE']['PvPRankNone']=... 

) add the line:

Code: Select all

$wordings['deDE']['Riding'] = 'Reiten'; 

- In deDE.php, add the array:

Code: Select all

$wordings['deDE']['Riding'] = array(
                'Nachtelf'=>'Ability_Mount_WhiteTiger',
                'Human'=>'Ability_Mount_RidingHorse',
                'Zwerg'=>'Ability_Mount_MountainRam',
                'Gnom'=>'Ability_Mount_MechaStrider',
                'Untoter'=>'Ability_Mount_Undeadhorse',
                'Troll'=>'Ability_Mount_Raptor',
                'Tauren'=>'Ability_Mount_Kodo_03',
                'Orc'=>'Ability_Mount_BlackDireWolf',
                'Paladin'=>'Ability_Mount_Dreadsteed',
                'Hexenmeister'=>'Ability_Mount_NightmareHorse'
); 

Hopes it will be integrated in the main branch.

Regards.
Romish

Romish wrote:Hopes it will be integrated in the main branch.

It is

i just thought about this thing a while. what about dwarfs riding tigers, humans riding mechanos, elfs ....

you dont have to ride your "race-mount". I have no char which is riding a different mount then his racemount but can the code sort it out??

btw: i have problems with german clients and dwarfs. in all my dwarf-chars there is no riding icon shown even if they can ride rams. is it a bug in the german version or only in my roster?? other german chars dont have this problem

SethDeBlade wrote:you dont have to ride your "race-mount". I have no char which is riding a different mount then his racemount but can the code sort it out??

As far as that logic goes, no. It specifies the racial mount only. I did suggest the idea of the roster checking the inventory of the character, and displaying accordingly, but that's a TON more work.
The skill "Riding" is a universal skill now, and it's just easier to list the racial mount than to include lines and lines more of code to sort out the inventory, and display whichever mount is there.

@Romish
Thank you very much, you did a wonderful job. Now we have nice riding skill icons back again

@SethDeBlade
Dwarfs mounts are displayed for me, pre and post riding skill fix.

Seth: Yes, you can adapt the code to show all mounts posessed by that character. This would require scanning the tooltip for all items that character has. Doing that for all chars is slow, so we're not gonna do it.

@rainrider in my char-page it is not shown

@pleegwat np, just an idea. as i said i dont need it for my guild.