Not really sure which version this bug might have first shown itself, but I have been updating using rosterdiag very frequently.
Entries for removals are appearing in the database in roster_memberlog but the only fields that are being populated are member_id, update_time and type.
The removals are not being displayed to the web page at all.
The last "good" removal entry I have was timestamped at 2007-09-25 20:33:20.

I should also say that memberlog entries look fine on my 1.7.3 install, so I don't think it has anything to do with GuildProfiler which I updated to 2.2.0 when the new version was released.

Manual uploading or are you using UniUpLoader ?

Koloth wrote:Not really sure which version this bug might have first shown itself, but I have been updating using rosterdiag very frequently.
Entries for removals are appearing in the database in roster_memberlog but the only fields that are being populated are member_id, update_time and type.

The removals are not being displayed to the web page at all.
The last "good" removal entry I have was timestamped at 2007-09-25 20:33:20.

I too, have just noticed this. I personally use UniUploader, but that has been working up until the 25 sept.

Check My Public Roster.

Using UU or manually uploading has no effect on the update process other than it returns text only when using UU

I just updated to svn1404, and I'm still not getting any of the member removals in member log either via manual uploading or armory sync. It only shows member additions.

We know about this error and it is still around

Members are not being deleted correctly in Roster at the moment and that is also causing this error

So far, this is what I found :

Goto line 510 in update.lib.php
Function update_guild() will reset the 'Active' flag.
Btw: update_guild() return a 'guild_id'.

What happens is that when the CP.lua is parsed arround line 527, the Active flag is set again for every member present in the CP.lua. These members stays in the Guild.

On line 539, remove_guild_members() is called.
remove_guild_members() CANNOT find any removed members, BECAUSE is searches for WHERE `guild_id` = '$guild_id' AND `active` = '0'.
This is ok, but the error is : the leaving members have there Active flag still set to zero (this is good) AND their 'guild_id' is also '0' :shock:
remove_guild_members() will not find any members to remove

Some has an idea where to look now ? Am I close ?
Who's setting 'guild_id' in the members table to zero ?


Also : the memberlog is Guild based :
it uses a ......WHERE `guild_id` = "'.$roster->data['guild_id'].'"'.
or, guild_id has been reset -> the leaving ones don't show up.

Line 527

Code: Select all

$memberid = $this->update_guild_member($guildId, $char_name, $realm_name, $region, $char, $currentTimestamp, $guild);

This function sets the `active` flag back to 1

Line 2589

Code: Select all

$this->add_value('active', '1');

I have an idea on how to fix this, but it's going to mess up all previously uploaded members

zanix wrote:...
This function sets the `active` flag back to 1
Line 2589

Code: Select all

$this->add_value('active', '1');

I know, I know.
But it really seems to me that update_guild_member() isn't called with an member_id that is about to be removed (because it's called with the members in the array in the CP.lua file - in the GP part).
Anyway, active isn't set for this guy, so ok.
guild_id is reset (btw 0 is it's default value) before update_guild_member() is called.

zanix wrote:I have an idea on how to fix this, but it's going to mess up all previously uploaded members

Deleted one by one all my guild member entries in my CP.lua for testing purposes. Image what this did this wy my roster data
I don't think a "messy solution" is needed - I want to know who's (where is) setting guild_id to zero, that all.

At first, I suspected the add_onhook chain, but disabling them in admin->config excluded that idea.

Ok. Go'ta stop being stupid.
As always, the solution isn't far away - better yet : in front of me.

Solution : open lib/update.lib.php, goto line 2346.

Find this :

Code: Select all

$querystr = "SELECT `member_id`, `name` FROM `" . $roster->db->table('members') . "` WHERE `guild_id` = '$guild_id' AND `active` = '0';";

change for

Code: Select all

$querystr = "SELECT * FROM `" . $roster->db->table('members') . "` WHERE `guild_id` = '$guild_id' AND `active` = '0';";

We have to select (nearly) all fields, and not only member_id and name in the members table because the row(s) is (are) transmitted to setMemberLog(..); who transmits thm entirely updateMemberlog(..), who actually needs all the info in the row to make a valid entry in the log, check lines 1030 and futher.

Proof : http://www.papy-team.fr/roster/index.ph ... rslist-log

Case closed

Ah yes, I wonder who did this....

Zanix quickly runs away from the blame

I still don't know what I have to do to make it work again.
Can I download a new version somewhere? I'm so not into this programming stuff...

Do you mean that you still using a 'before' version 1386 ???

Because this issue has been taken care of a long time ago.

Hummmm. You know, don't worry - you don't need to be a programmer to update your software - thinks about these 350 million Windows users
Especially if you're using beta software - and Bliz is changing its stuff also all the time.

Try doing a update - and if things don't work out, you might be better of wiping your database - and do a complete re-install of the roster.