Jewelcrafting

Requests, feedback, and general discussion about WoWRoster
DO NOT post topics about WoWRoster AddOns here!

Jewelcrafting

Postby bbj911 » Sat Jan 20, 2007 4:39 am

Ok, ive managed to fix the missing icon for the jewelcrafting,

I have not been able to fix the missing jewelcrafting entry for the "Professions" button.

Any ideas ?

PS - Yes i did do a search.....
User avatar
bbj911
WR.net Apprentice
WR.net Apprentice
 
Posts: 61
Joined: Mon Oct 23, 2006 6:47 pm

Re: Jewelcrafting

Postby Nimbis » Mon Jan 22, 2007 6:31 am

I am also having an issue getting the jewelcrafting icon to show up. It is as if the icon image is missing. I have updated my image packs and everything. =(

EDIT!

I went to work on this myself and wrote a fix HERE.
Last edited by Nimbis on Mon Jan 22, 2007 7:28 am, edited 1 time in total.
User avatar
Nimbis
WR.net Apprentice
WR.net Apprentice
 
Posts: 4
Joined: Wed Dec 20, 2006 3:37 am

Jewelcrafting

Postby bbj911 » Mon Jan 22, 2007 11:33 am

I did say that i managed to fix the missing icon bit. The problem i have is with the tradeskills showing up when u click the professions button on the roster menu. jewelcrafting does not show up there are a proffesion......
User avatar
bbj911
WR.net Apprentice
WR.net Apprentice
 
Posts: 61
Joined: Mon Oct 23, 2006 6:47 pm

Jewelcrafting

Postby bbj911 » Mon Jan 22, 2007 11:46 am

found the problem. the number of tradeskills is hardcoded in tradeskills.php
find
Code: Select all
// Build a list of "Skills" to look for
$inClause '';
for (
$tsNr=0$tsNr<=11$tsNr++ )
 


and replace with
Code: Select all
// Build a list of "Skills" to look for
$inClause '';
for (
$tsNr=0$tsNr<=13$tsNr++ )
 


At some point i guess we should rather let it use a count of the tradeskills array.
User avatar
bbj911
WR.net Apprentice
WR.net Apprentice
 
Posts: 61
Joined: Mon Oct 23, 2006 6:47 pm

Jewelcrafting

Postby PleegWat » Mon Jan 22, 2007 1:51 pm

Fixed for 1.7.3b2. I don't know who coded it like that, but the new version should work independant of the number of different skills.
I <3 /bin/bash
User avatar
PleegWat
WoWRoster.net Dev Team
WoWRoster.net Dev Team
 
Posts: 1636
Joined: Tue Jul 04, 2006 1:43 pm


Return to General Support & Feedback

Who is online

Users browsing this forum: No registered users and 1 guest