Using SigGen 2.0,

In SigGen Config, under Char/Class/PvP Logo, PvP Logo Display - setting this to on or off makes no difference, the logo does not appear anywhere on the Signature or on the Avatar. Any ideas?

Make sure you have the pvp logo image pack set to something other than None

Also, the pvp logo this looks for is the current rank, not the lifetime highest rank

The PvP logo image pack is set to Default

Is there some other option that has to be turned on for them to display?

The character has to have info for their current rank in the database

OK. Looks like other members PvP ranks are displaying, it's just mine that is not.

I think it is because my character is missing its "Current Honor Rank".

What is odd is that I can go into "Honor" and it shows me as "Knight-Champion" along with everyone else's appropriate honor rank. But, back in normal Roster view, my "Current Honor Rank" is blank.

Thinking my profile in database was screwed up, I looked in the Roster_Players table and found that is shows:

lifetimeRankName : Knight-Champion
lifetimeHighestRank : 9
RankInfo : 0
RankName : None
RankIcon : Interface/PvPRankBadges/

Shoudn't there be entries for RankInfo and RankName?


I've rescanned by character and still not being input into the system for some reason.

I edited the following fields as follows:

RankInfo : 9
RankName : Knight-Champion
RankIcon : Interface/PvPRankBadges/PvPRank09

Now, everything seems OK. My Current Honor Rank now displays and my PvP icon appears on Sig and Avatar.

Not sure if it will stay though. Is there something I did wrong initially for this data not to get loaded?

Not sure, maybe the data just wasn't scanned

So, after I ran another scan of my character and then uploaded the .lua file, it wipes out the manual settings I made above.

So, why would CP not be grabbing my current honor rank? I have scanned all tabs under my character portrait including PvP. Is there some other tab in the game that has existing rank / lifetime rank that I may be missing?

I just noticed a couple of other members are exhibiting the same results.

To be honest, I'm not sure

Having the same problem.

This is happening when I update using the new modified luaparser.

Everyone who last updated before the 12/1, when i updated the luaparser, still has their correct PVP ranks.

You are correct. After I uploaded the new parser fix is when this problem became noticeable.

Looks like the current honor Rank is no longer in CP.lua

Code: Select all

["Honor"] = {
   ["Yesterday"] = {
      ["HK"] = 0,
      ["CP"] = 0,
   },
   ["Current"] = {
      ["Name"] = "none",
      ["HonorPoints"] = 4084,
      ["Progress"] = "0.00",
      ["ArenaPoints"] = 0,
      ["Icon"] = "",
      ["Rank"] = 0,
   },
   ["Session"] = {
      ["HK"] = 0,
      ["CP"] = 0,
   },
   ["Lifetime"] = {
      ["Rank"] = 5,
      ["Name"] = "Sergeant Major",
      ["HK"] = 2026,
   },
},


Looks like I'll need to edit SigGen to just display the lifetime PvP rank

zanix wrote:Looks like the current honor Rank is no longer in CP.lua
...
Looks like I'll need to edit SigGen to just display the lifetime PvP rank

I'd actually hacked (and by hacked, I mean brutally and inefficiently) this change into an earlier version since "Current Rank" really doesn't have any meaning following the latest patches:

Code: Select all

      // Remove crap from pvprankicon
      $remove_arr = array('Interface','\\','PvPRankBadges');

      switch( $playersData['lifetimeHighestRank'] )
      {
      case "14":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank14";
      break;
     
      case "13":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank13";
      break;

      case "12":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank12";
      break;

      case "11":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank11";
      break;

      case "10":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank10";
      break;
     
      case "9":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank09";
      break;

      case "8":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank08";
      break;

      case "7":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank07";
      break;

      case "6":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank06";
      break;
     
      case "5":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank05";
      break;
     
      case "4":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank04";
      break;

      case "3":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank03";
      break;

      case "2":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank02";
      break;
     
      case "1":
      $hrank_icon = "/Interface/PvPRankBadges/PvPRank01";
      break;

      default:
      $hrank_icon = "/Interface/PvPRankBadges/PvPRankHorde";
      break;
      };

//    $sig_pvp_icon = str_replace($remove_arr,'',$playersData['RankIcon']);
    $sig_pvp_icon = str_replace($remove_arr,'',$hrank_icon);


Ugly, but functional.

Yeah, very hacked...hehe
It does work, however I will be fixing this for my next release in my own special way

zanix wrote:Yeah, very hacked...hehe
It does work, however I will be fixing this for my next release in my own special way

Thank the stars you're not going to implement that cruft I used. ;-)