Zanix, I don't see why that's a problem. You've been saying yourself that we need a reason to make stuff really 3.x incompatible to stop support requests on that. This seems an excellent thing for it.

PleegWat wrote:Zanix, I don't see why that's a problem. You've been saying yourself that we need a reason to make stuff really 3.x incompatible to stop support requests on that. This seems an excellent thing for it.

Yeah, that's true
Then we wouldn't have to utf8-encode anything anymore
Then the localization files would be readable

I think this should be in Roster 2, make the database tables utf-8...

I've just finish a frFR translation for 1.7.1, I will test it when I return home this evening.

It seems to work

but I haven't translate some admin values ( lack of time yesterday for european servers was patch day, and when it's patch day, no play )

Cool, thanks Exerladan, wowodo, lesablier, and Ansgar
I have compiled a master file of the submitted frFR.php files form this forum topic

I have attactched it to the first post

Some translations changed with patch 1.12 (clé Shadowforge => Clé ombreforge)

I continue to translate admin values.

Can you use the file from the first post for roster 1.7.1?
Some things were added/changed

zanix wrote:Can you use the file from the first post for roster 1.7.1?
Some things were added/changed

Ok no problem, I'll do it today

Exerladan wrote:

zanix wrote:Can you use the file from the first post for roster 1.7.1?
Some things were added/changed

Ok no problem, I'll do it today

Yay!

Lack of some admin values (maybe this evening).

Some Horde keys are not translated, I'll check with wowdbu or judgehype (but those sites are banned at work )

A little lack in 1.7.0 and may be in 1.7.1 in css/styles.css file :

Code: Select all

.classDruidetxt { color:#A69D91; }
.classChasseurtxt { color:#FFC835; }
.classMagetxt { color:#E11C14; }
.classPaladintxt { color:#B5BDB0; }
.classPrêtretxt { color:#48CBBD; }
.classVoleurtxt { color:#C3EB88; }
.classChamantxt { color:#7B480C; }
.classDémonistetxt { color:#A07AAD; }
.classGuerriertxt { color:#3C77B3; }

The code to add to lib/wowdb.php to handle utf8 in database

Code: Select all

   /**
    * Change DB encoding to UTF8
    *
    * @return bool
    */
   function changeDBEncoding()
   {
      $prefix = substr( ROSTER_CONFIGTABLE , 0, - strlen( 'config' ) );
      $tableResult = $this->query( 'SHOW TABLES' );
      while( $table = $this->getrow( $tableResult ) ) {
         $tableName = $table[key($table)];
         if ( substr( $tableName, 0, strlen( $prefix ) ) == $prefix ) {
            $this->query( 'ALTER TABLE `'.$tableName.'` DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci' );
         }
         $columnResult = $this->query( 'SHOW COLUMNS FROM `'.$tableName.'`' );
         while( $column = $this->getrow( $columnResult ) ) {
            if ( ( substr( $column['Type'], 0, 7 ) == 'varchar' ) || ( substr( $column['Type'], 0, 4 ) == 'char' ) || ( substr( $column['Type'], 0, 4 ) == 'text' ) ) {
               $this->query( 'ALTER TABLE `'.$tableName.'` CHANGE `'.$column['Field'].'` `'.$column['Field'].'` '.$column['Type'].' CHARACTER SET utf8 COLLATE utf8_general_ci' );
            }
         }
      }
      return true;
   }
   
   /**
    * Change client encoding to UTF8
    *
    * Execute this method before any other query
    *
    * @return bool
    */
   function changeClientEncoding()
   {
      $this->query( 'SET CHARACTER SET \'utf8\'' );
      return true;
   }
   
    /**
    * Get MySQL version
    *
    * Execute this method before any other query
    *
    * @return string
    */
   function getMySQLVersion()
   {
      $result = $this->query( 'SHOW VARIABLES LIKE \'version\'' );
      $version = $this->getrow( $result );
      return $version['Value'];
   }

I have not test the code yet, 'cause I'm at work and I can't access to SVN (I even don't know if SVN has a public access ) so I can't install the 1.7.1... I will test it this evening if I'm not in raid

Sorry I hav'nt tested the code with roster 1.7.1 : I was too busy yesterday, I just dinged exalted at Thorium Brotherhood ( if you're interested in Dark Iron Boots /w Exerladan on EU-Archimonde (frFR PvP) / si vous êtes intéressé par les bottes en sombrefer /w Exerladan sur EU-Archimonde (frFR PvP) )

Cool, updated SVN with your latest fixes Exerladan

Do you have a deadline for the 1.7.1 project? When it will be available for download?