emilise wrote:Well I know why it doesn't sort in english, it is a problem in the localization file.
The two lines
$lang['GDmajor']=" major";
$lang['GDminor']=" minor";

should be :

$lang['GDmajor']="Major ";
$lang['GDminor']="Minor ";

These two lines are used to detect if this is a major or minor glyph and the words are not in the same order in French and English.

Gotta love it when a simply case glitch screws things up, lol. Or rather the space (just noticed that space hiding there at the start, then moved to the end, lol. (I just woke up, am not seeing clearly yet, haha)

Casing in filenames:

On a windows server, this will not matter. Mismatched case will still include the right file.

On a linux server, it does matter. An include call to 'enUS.php' will not include an actual file called 'enus.php'.

Calystos wrote:Gotta love it when a simply case glitch screws things up, lol. Or rather the space (just noticed that space hiding there at the start, then moved to the end, lol. (I just woke up, am not seeing clearly yet, haha)

Yes, in English you read "Major glyph", while in French you read "Glyphe majeur", that's why the case changes and the space too.

Also just noticed another possible glitch in the enUS.php file.

Code: Select all

//color
$lang['GDclass']['demo']="Warlock";
$lang['GDclass']['chaman']="Shaman";
$lang['GDclass']['chasseur']="Hunter";
$lang['GDclass']['war']="Warrior";
$lang['GDclass']['pretre']="Priest";
$lang['GDclass']['mage']="Mage";
$lang['GDclass']['druide']="Druid";
$lang['GDclass']['dk']="Death Knight";
$lang['GDclass']['paladin']="Paladin";
$lang['GDclass']['voleur']="Rogue";


Should be:

Code: Select all

//color
$lang['GDclass']['warlock']="Warlock";
$lang['GDclass']['shaman']="Shaman";
$lang['GDclass']['hunter']="Hunter";
$lang['GDclass']['warrior']="Warrior";
$lang['GDclass']['priest']="Priest";
$lang['GDclass']['mage']="Mage";
$lang['GDclass']['druid']="Druid";
$lang['GDclass']['dk']="Death Knight";
$lang['GDclass']['paladin']="Paladin";
$lang['GDclass']['rogue']="Rogue";


Shouldn't it?

EDIT: Slight additional change, added missing "var $wrnet_id = 0;" to the install php file. And re-archived and uploaded the lot.

Hi there,

Fot the $lang['GDclass'] array, it doesn't have any importance. We could use
$lang['GDclass'][] = 'Warlock", it would work as well. I think I will do that!

For the == or ===, it is important to keep the 3 =. See the warning in http://fr2.php.net/manual/fr/function.strpos.php for the reason why.

emilise wrote:Hi there,

Fot the $lang['GDclass'] array, it doesn't have any importance. We could use
$lang['GDclass'][] = 'Warlock", it would work as well. I think I will do that!

For the == or ===, it is important to keep the 3 =. See the warning in http://fr2.php.net/manual/fr/function.strpos.php for the reason why.

Heh, a quick trip to the EN version an yeah I see.

I'm so used to programming in C not PHP, and there is no === option. So at first I thought it was a typo, lol.

Slight oversight on my behalf there on the spacing in "Major " and "Minor "

Anyhow, installed the latest version, and for some reason I don't get the "menu" on top where you have the links to the various glyph types, or the icon to collapse each box.
http://roster.treehuggery.org/index.php ... play&a=g:1

A quick german (deDE) localisation.

Code: Select all

<?php
/**
 * WoWRoster.net WoWRoster
 *
 * LICENSE: Licensed under the Creative Commons
 *          "Attribution-NonCommercial-ShareAlike 2.5" license
 *
 * @copyright  2002-2007 WoWRoster.net
 * @license    http://creativecommons.org/licenses/by-nc-sa/2.5   Creative Commons "Attribution-NonCommercial-ShareAlike 2.5"
 * @link       http://www.wowroster.net
 * @package    GlyphsDisplay
 * @subpackage Installer
*/

$lang['GlyphDisplay_menu'] = 'Glyphen|Zeigt Glyphen an die von Gildenmitgliedern hergestellt werden können.';
$lang['glyph_title_addon'] = 'Glyphen';

$lang['Glyph_title']="Glyphe";
$lang['Objet']='Objekt';
$lang['Name']='Name';
$lang['level']='Level';
$lang['compo']='Materialien';
$lang['crafter']='Kann hergestellt werden von';
$lang['Filter']='Filter';
$lang['NoFilter']='Kein Filter';

//Craft Name
$lang['Glyph']="Glyphe";
$lang['sill']="Inschriftenkunde";

//slot name
$lang['slot']="Glyphe";
$lang['GDmajor']="Erhebliche ";
$lang['GDminor']="Geringe ";

//color
$lang['GDclass'][]="Hexenmeister";
$lang['GDclass'][]="Schamane";
$lang['GDclass'][]="Jäger";
$lang['GDclass'][]="Krieger";
$lang['GDclass'][]="Priester";
$lang['GDclass'][]="Magier";
$lang['GDclass'][]="Druide";
$lang['GDclass'][]="Todesritter";
$lang['GDclass'][]="Paladin";
$lang['GDclass'][]="Schurke";

$lang['admin']['gld_main_conf'] = 'Allgemeine Einstellungen';
$lang['admin']['gld_expand'] = 'Ansicht standardmäßig erweitern / reduzieren ?|Anzeige der Glyphen standardmäßig geschlossen / geöffnet anzeigen.';
$lang['admin']['gld_order'] = 'Standard Sortierung|Kategorie Sortierung nach erheblich / gering umschalten.';

?>

Can't you use one of the global class arrays (like id_to_class) to get a list of class names?

Wyren I suspect you took your version from this forum, and not in the download section.

Thanks Grektar for the localization ! I will include it soon.

PleegWat : I didn't know that exists. I'm very new to addon development. Thanks for the advice.

Greetings,

Where can we get the icons/graphics for this ?

Hi,

I think that the icons are committed on SVN, you can just update them from here

http://svn.wowroster.net/interface/40x40/Icons/

emilise wrote:Hi,

I think that the icons are committed on SVN, you can just update them from here

http://svn.wowroster.net/interface/40x40/Icons/

Handy to know. With that clue, I added the svn:externals property to the Interface directory of my working copy with this content:

Code: Select all

Icons   http://svn.wowroster.net/interface/40x40/Icons
ItemSocketingFrame      http://svn.wowroster.net/interface/40x40/ItemSocketingFrame
PvPRankBadges   http://svn.wowroster.net/interface/40x40/PvPRankBadges
Spellbook       http://svn.wowroster.net/interface/64x64/Spellbook
TalentFrame     http://svn.wowroster.net/interface/40x40/TalentFrame

I'm trying to find it now in the code, but maybe someone can answer it before I mess up the file too badly. When I click on the links at the top where it says Death Knight - Minor (any of those links) it takes me to my home page. I suspect it may have something to do with this line in the template.inc.php file:

Code: Select all

$tmp[] = '<a href="'.$url.'#'.$id.'" title="'.$type.'" onclick="javascript:show(\'table'.$id.'\');">'.$type.'</a>'; 

but not entirely sure what to do with it.

Thanks for any and all help.

EDIT:
Oh, my roster is located at http://guildofhardknocks.com/roster

Hi Djuwal,

The line that doesn't work is in fact this one :

Code: Select all

$url = 'http://'.$_SERVER['HTTP_HOST'].$_SERVER['REQUEST_URI']; 

It seems that the $_SERVER['REQUEST_URI'] is null on your server. Could you please add this line

Code: Select all

var_dump($_SERVER); 

just below the one I quoted here, upload the modified file to your server and copy here what it shows on your roster.

You can see on your roster that the links are wrong since they show i.e. http://guildofhardknocks.com/#DeathKnight-Major instead of http://guildofhardknocks.com/roster/ind ... ight-Major