Jewelcrafter addon

Display what gems jewelcrafters can make

Moderator: titan99

Re: Jewelcrafter addon

Postby edse » Thu Mar 29, 2007 4:57 pm

I am getting the same error as Rajaat. It is displayed on the main page in the box for the blue gems.

Warning: Invalid argument supplied for foreach() in public_html/roster/addons/Gemme/index.php on line 130

I'm using enUS as rosterlang so this shouldn't be the problem.

Can anyone give some help with this?
edse
WR.net Apprentice
WR.net Apprentice
 
Posts: 4
Joined: Tue Jan 02, 2007 5:00 am

Re: Jewelcrafter addon

Postby Tyradil » Thu Mar 29, 2007 5:12 pm

Lol, this is the result of a little typo and only occurs when no (blue) gems where found. ;-)

Just fix this by replacing index.php, line 54
Code: Select all
$type['bleu']=array();


with

Code: Select all
$type['blue']=array();


Greetings
Tyradil
author of the addon "Faction Rewards" - http://www.wowroster.net/Forums/viewforum/f=102.html

Image
User avatar
Tyradil
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 35
Joined: Thu Oct 26, 2006 5:13 pm

Jewelcrafter addon

Postby Subxero » Thu Mar 29, 2007 6:42 pm

Great work Titan99 and Tyradil.

with the suggest changes from tyradil works perfectly

Suggestions for major next version:
-Aditional sort on every color (red,blue,yellow):
sort by quality, group by blue (nightseye,living ruby) and green quality (Shadow Draenite,Blood Garnet) ..
sort by pure colors blues,purple(red+blue),orange(yellow+red)...

Example of sorts with Blue gems

Actual sort:
*alfabetical
Azure Moonstone
Deep Peridot
Nightseye
Shadow Draenite
Star of Elune
Talasite

By quality:
*greens
Azure Moonstone
Deep Peridot
Shadow Draenite
*blues
Nightseye
Star of Elune
Talasite

By pure colors:
*pure blue
Azure Moonstone
Star of Elune
*green (blue+yellow)
Deep Peridot
Talasite
*violet (blue+red)
Shadow Draenite
Nightseye

-Manual fix of blizzard bug that make "Stormy Star of Elune" its not a gem ?
http://www.thottbot.com/i24039 Now is considered a Trade good not a gem.
User avatar
Subxero
WR.net Artisan
WR.net Artisan
 
Posts: 234
Joined: Thu Jul 06, 2006 4:08 pm
Realm: Zul'jin (PvE) - US

Re: Jewelcrafter addon

Postby edse » Thu Mar 29, 2007 6:48 pm

Thanks Tyradil

Works fine now.

:thumright:
edse
WR.net Apprentice
WR.net Apprentice
 
Posts: 4
Joined: Tue Jan 02, 2007 5:00 am

Re: Jewelcrafter addon

Postby Rajaat » Fri Mar 30, 2007 3:07 am

Mucho thanks!

Rock on! :mrgreen:
Rajaat
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Thu Mar 29, 2007 8:33 am

Re: Jewelcrafter addon

Postby Stumblefoot » Fri Mar 30, 2007 7:06 am

Nice - thx

I have one request
If you could make the list of who can make the different gems appear like in the Made By addon

You know ppl are colored by skill lvl, and on mouseover you can see their skill.. :) that would put this addon over the top.. :)


Oh and one last thing - could you make the Item Description: visible (as in the made by addon) - I personally thinks its easier to scan for that gem if i can read it right of the page, and not needing to hover the mouse on each gem.. :)
Last edited by Stumblefoot on Fri Mar 30, 2007 7:22 am, edited 1 time in total.
Stumblefoot
WR.net Apprentice
WR.net Apprentice
 
Posts: 1
Joined: Thu Jan 11, 2007 2:04 am

Jewelcrafter addon

Postby Escobar » Sat Mar 31, 2007 1:19 pm

Nice Addon thx... but i have a Error
i don't now what is a problem!


Image
Code: Select all
Warning: Invalid argument supplied for foreach() in /www/htdocs/xxxxxxxx/phpbb2/Roster/addons/Gemme/index.php on line 130

Code: Select all
127 <?php
128    $tmp=$type[$keyColor];
129
130    foreach($tmp as $item)
131    {
132     $tooltip = makeOverlib($item['recipe_tooltip'],'',$item['item_color'],0,$lang);
133     $itemAff = '<div class="item" '.$tooltip.'>';
134     $itemAff.="<img src=\"".$roster_conf['interface_url'].$item['recipe_texture'].".jpg\" class=\"icon\" alt=\"\" />";
135     $itemAff.='</div>';
136     
137     $query = "SELECT M.name
138             FROM `".ROSTER_RECIPESTABLE."` R, `".ROSTER_MEMBERSTABLE."` M
139             WHERE R.member_id=M.member_id
140           AND R.`recipe_name` = '".addslashes($item['recipe_name'])."'
141           ";
142
143     $result = $wowdb->query($query) or die_quietly($wowdb->error(),'Database Error', basename(__FILE__),__LINE__,$query);
144     
145     $craftName='';
146     
147     while($row = $wowdb->fetch_array($result))
148     {
149         $craftName.=$row[name].", ";
150     }
151 ?>

Thanks for the Help...
User avatar
Escobar
WR.net Apprentice
WR.net Apprentice
 
Posts: 2
Joined: Fri Nov 10, 2006 1:47 pm

Re: Jewelcrafter addon

Postby Tyradil » Sat Mar 31, 2007 5:07 pm

Scroll 5 posts above, or follow the link
http://www.wowroster.net/Forums/viewtop ... html#19123

There I already posted the solution. ;-)

Greetings
Tyradil
author of the addon "Faction Rewards" - http://www.wowroster.net/Forums/viewforum/f=102.html

Image
User avatar
Tyradil
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 35
Joined: Thu Oct 26, 2006 5:13 pm

Re: Jewelcrafter addon

Postby Pops » Sat Apr 28, 2007 4:50 am

Any news on if there is a fix to the Star of elune, since its catagorized as a trade good? This mod is fantastic btw. My guild loves it.
Pops
WR.net Apprentice
WR.net Apprentice
 
Posts: 14
Joined: Tue Mar 27, 2007 9:55 pm

Jewelcrafter addon

Postby IsaacQuotien » Wed May 09, 2007 4:08 pm

running into this error...looked through the posts and didnt see it posted before.

Parse error: syntax error, unexpected $end in /roster/addons/Gemme/index.php on line 180

any ideas?
IsaacQuotien
WR.net Apprentice
WR.net Apprentice
 
Posts: 5
Joined: Sun Apr 22, 2007 4:12 am

Re: Jewelcrafter addon

Postby daysee » Tue May 15, 2007 10:46 pm

Tyradil wrote:Lol, this is the result of a little typo and only occurs when no (blue) gems where found. ;-)

Just fix this by replacing index.php, line 54
Code: Select all
$type['bleu']=array();


with

Code: Select all
$type['blue']=array();


Greetings
Tyradil


Thank you for the posted fix. Maybe you should update your download?
Image
User avatar
daysee
WR.net Apprentice
WR.net Apprentice
 
Posts: 12
Joined: Mon Jul 10, 2006 12:23 am

Re: Jewelcrafter addon

Postby Tyradil » Wed May 16, 2007 9:38 pm

daysee wrote:Thank you for the posted fix. Maybe you should update your download?


I'm not the author of this addon, I'm just using it too and giving some support, because I like it very much. The original author is titan99, but he seams to be not so active at the moment.
(And the typo was my fault, because I send this piece of code to him, so I felt like having to fix it. ;-) )
author of the addon "Faction Rewards" - http://www.wowroster.net/Forums/viewforum/f=102.html

Image
User avatar
Tyradil
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 35
Joined: Thu Oct 26, 2006 5:13 pm

Re: Jewelcrafter addon

Postby daysee » Wed May 16, 2007 10:36 pm

Ahhh, yes, my mistake, Tyradil.

Thank you nonetheless for adding your fixes and code snippets.

I've gotten my first JC to upload so I can actually see the mod working and I love it. Great idea.

Only suggestion I have for a future release is to remove the comma after the crafters name should there be only one crafter. as it is now I only have one JC uploading and the crafters list appears as:

CrafterName,

With a comma, but no following crafter name. I'm sure this could be fixed with a simple if results>1....I'll post a fix should I get around to finding the line..
Image
User avatar
daysee
WR.net Apprentice
WR.net Apprentice
 
Posts: 12
Joined: Mon Jul 10, 2006 12:23 am

Re: Jewelcrafter addon

Postby Tyradil » Wed May 23, 2007 9:20 pm

Np. :-)

daysee wrote:Only suggestion I have for a future release is to remove the comma after the crafters name should there be only one crafter. as it is now I only have one JC uploading and the crafters list appears as:

CrafterName,

With a comma, but no following crafter name. I'm sure this could be fixed with a simple if results>1....I'll post a fix should I get around to finding the line..


Try replacing index.php, around line 150:

Code: Select all
    while($row = $wowdb->fetch_array($result))
    {
        $craftName.=$row[name].", ";
    }


with:

Code: Select all
    $craftSeperator = false;
    while($row = $wowdb->fetch_array($result))
    {
        if ($craftSeperator == true)
             $craftName.= ", ";
        $craftName.=$row[name];
        $craftSeperator = true;
    }


This should do it. :-)
author of the addon "Faction Rewards" - http://www.wowroster.net/Forums/viewforum/f=102.html

Image
User avatar
Tyradil
Roster AddOn Dev
Roster AddOn Dev
 
Posts: 35
Joined: Thu Oct 26, 2006 5:13 pm

Re: Jewelcrafter addon

Postby lunzet » Wed May 23, 2007 10:04 pm

Is it still working for anybody after the 2.1.0 patch? My roster does not show any gems anymore....just blank...no errors. I have already updated the gp and cp but still no luck...anybody else?
User avatar
lunzet
WR.net Journeyman
WR.net Journeyman
 
Posts: 119
Joined: Sat Jan 13, 2007 1:23 pm

PreviousNext

Return to Gems Display

Who is online

Users browsing this forum: No registered users and 0 guests

cron