By the way shadydude,
At the time I posted, your signature had an error
I'm posting it (edited to remove sensitive info) just in case you fix it before you see this post

I'm almost considering using something like that as my signature now, lol

Thanks for the offer Zanix, that'd be great.
Sorry I haven't been around much, I've been busy with school and work but I've got some new features heading your way.

Can we get this mod added to the roster downloads section ?

Kudos on the mod! We love it.

[This post handles the Guild Bank Add On with item request facilities]

Some item requests gave me a strange results :

Notice: Undefined variable: itemdata in /..... ..../roster/addons/guildbank/request.php on line 313
Réservation
Cet objet n'est pas dans la banque.

{usUS Error : [....]['gb_err_notinbank'] = "That item is not in the guild/bank."}
I'm using the frFR version. And please note that the line number can be somewhat different - I'm patching arround
I'm pretty sure that this isn't a localization related error.

What happens :
This line (in request.php) :

$query = "SELECT member.name as member_name, member.member_id as member_id, item.* FROM `".ROSTER_ITEMSTABLE."` as item LEFT JOIN `".ROSTER_MEMBERSTABLE."` as member ON item.member_id=member.member_id WHERE item.item_id LIKE '".$itemid.":%' AND member.".$roster_conf['banker_fieldname']." LIKE '%".$roster_conf['banker_rankname']."%' AND item.item_parent!='bags' AND item.item_parent!='equip' AND item.item_tooltip NOT LIKE '%".$wordings[$roster_conf['roster_lang']]['tooltip_soulbound']."%' ORDER BY item.item_name";

should be

$query = "SELECT member.name as member_name, member.member_id as member_id, item.* FROM `".ROSTER_ITEMSTABLE."` as item LEFT JOIN `".ROSTER_MEMBERSTABLE."` as member ON item.member_id=member.member_id WHERE item.item_id LIKE '".$itemid.":%' AND member.".$roster_conf['banker_fieldname']." LIKE '%".$roster_conf['banker_rankname']."%' AND item.item_parent!='bags' AND item.item_parent!='equip' AND (item.item_tooltip NOT LIKE '%".$wordings[$roster_conf['roster_lang']]['tooltip_soulbound']."%' OR item.item_tooltip LIKE '%".$wordings[$roster_conf['roster_lang']]['tooltip_boe']."%') ORDER BY item.item_name";

{this line has to be replaced twice...}

Didn't even have to type it : copied it right from de gbank.php file, where the same SQL SELECT can be found.

The final issue is : the SELECT has to exclude bank-items that are soulbound but not the ones that are soulbound when equiped.
Is is quit logic, one can't transfer a soulbound items anyway. They shoudn't be in the bank sacs of a bank character.

The SELECTing goes well now : no more errors when requesting an item by our membres.

It's solved for me ..

This is one hell of a Add On : Pleegwat : I also vote for a separte forum and Download Section.

Don't work for me...

And I don't see this line in the gbank.php file...

Malkom wrote:And I don't see this line in the gbank.php file...

The 2 lines to changes are in request.php - as stated above.
gbank.php doesn't have any problem for me.

this might be a language issue after all.

Just starting using this mod and it is really awesome!

I have a couple of feature requests, that might be specific to our guild, it might not, but ill give it a shot..

We use the first come, first serve for the majority of items in the bank, but for epics, we force people to request it via our forums, so that if other members want to request it, they can also, then it goes to a roll off.

I guess im looking for one of the following;

1) For certain item color, make it so the request cant be done (so, say for epics, it can have a custom link to somewhere)

or

2) Make it so certain color items (selectable in admin or conf), that they stay on the bank list after one person has requested it, and allow multiple people to select it. This can happen until the bank has accepted the item to go out (and user if poss).


The other request is, we are always looking for ways to keep people updating their data onto the roster. It would be great to be able to have it so when people request stuff, if they havent updated their data within x days, they arent able to request the item.

darthgus wrote:The other request is, we are always looking for ways to keep people updating their data onto the roster. It would be great to be able to have it so when people request stuff, if they havent updated their data within x days, they arent able to request the item.

Agree with that one!
And I can handle that question !!

So, in the request.php file, change this function function createMemberlist($name)

Make it like this :

Code: Select all

function createMemberlist($name)
{
  global $wowdb, $addon_conf, $roster_conf, $phptimeformat;
   
  $list = "<SELECT name='accname'>\n";
  $currenttime = time();

  $query = "SELECT `members`.`member_id`, `members`.`name`, dateupdatedutc ";
  $query .= "FROM `".ROSTER_PLAYERSTABLE."` as members ";
  $query .= "LEFT JOIN `".ROSTER_MEMBERSTABLE."` AS players ON `members`.`member_id` = `players`.`member_id` ";
  $query .= "WHERE guild_rank <= ".$addon_conf['guildbank']['rank']." ORDER BY name";
 
  $result = $wowdb->query($query) or die_quietly($wowdb->error(),'Database Error',basename(__FILE__),__LINE__,$query);

  while( $rawlist = $wowdb->fetch_assoc($result) )
  {
    list($month,$day,$year,$hour,$minute,$second) = sscanf($rawlist['dateupdatedutc'],"%2d/%2d/%2d %2d:%2d:%2d");
    $localtime = mktime($hour+$roster_conf['localtimeoffset'] ,$minute, $second, $month, $day, $year, -1);
      
    if (($localtime + (7 * 24 * 60 * 60)) > $currenttime ) {
      if($rawlist['member_id'] === $name) {
        $list .= "\t<OPTION SELECTED value='".$rawlist['member_id']."'>".$rawlist['name']."</OPTION>\n";
        }
        else {
          $list .= "\t<OPTION value='".$rawlist['member_id']."'>".$rawlist['name']."</OPTION>\n";
            }
      }
    }

  $list .= "</SELECT>\n";

  return $list;
}

Of course, the 7 days limit is hard coded here (can you see it ?) - and should be more accesible, like setting it in the conf.php file of the gbank add on.

But, hey, I'm only coding SQL for a couple of days now

I tried it : it just rocks !!

Thanks for the fix and the mod tuigii.

Hopefully GB version 2 will be released shortly.

OK tuigi I've found the second line in the request.php file ^^

So first line is 78 and second is 236.

Work fine now !!!

I'm so enjoy ^^

Averen, I've another little problem....

When I use your add, level filters don't work.... and when I install this fix on the CatGuildBank (http://www.wowroster.net/Forums/viewtopic/t=2588.html file on the sturmy's post), level filters work fine....

I've tried to mix the two files... but to hard for me

Can you do it please.... ?

Thank you in advance ^^

Malkom wrote:Averen, I've another little problem....

When I use your add, level filters don't work.... and when I install this fix on the CatGuildBank (http://www.wowroster.net/Forums/viewtopic/t=2588.html file on the sturmy's post), level filters work fine....

I've tried to mix the two files... but to hard for me

Can you do it please.... ?

Thank you in advance ^^

Averen,

Nothing to do !! I have found the problem... (thx to DirtyHerri)


In the localization file, for the french translation, replace "Niveau requis" with "Niveau"

It's work fine ^^

Malkom wrote:In the localization file, for the french translation, replace "Niveau requis" with "Niveau"

It's work fine ^^

Yep, logic 'cause the format is Niveaux xx requis so the match will not be made, there is a number in it.

But, better yet : try to filter for a 'Plan' and, i.e. "all items between 1 min and 25 max".
It will not work correctly. Items of more then 25 will be included in the found list...
Have a look at the SQL request generated
To make a long story short, I changed this part :

Code: Select all

$lvlItemQuery = ' AND `item_tooltip` REGEXP \''.$wordings[$roster_conf['roster_lang']]['reqlevel'].' (('.$min.')';
  for ($i = $min + 1;$i <= $max;$i++)
  {
     $lvlItemQuery .= '|('.$i.')';
  }

for this :

$lvlItemQuery = ' AND `item_tooltip` REGEXP \''.$wordings[$roster_conf['roster_lang']]['reqlevel'].' (( '.$min.')';
for ($i = $min + 1;$i <= $max;$i++)
{
if ($i<10)
{ $lvlItemQuery .= '|( '.$i.')';
} else
{ $lvlItemQuery .= '|('.$i.')'; }

The thing that did the work is the 'space' between the "(" and the "'" - can you see it ? (in the middle of the red zone).

Why ? test with the min=1 & max=1, the REGEXP will give a positive result for "Niveau 1x", x being anything / or nothing, so "Niveau 1" will do, but "Niveau 15" also. This is wrong.

Including a space in front of it (for numbers below 10) - and the search goes well...

Averen wrote:1. Guild leader - YES
2. Officer - YES
3. Memer - YES
4. Initiate - NO

Hello,

nice addon

is it possible to add a new option for the reservation?

Code: Select all

1. Guild leader - YES
2. Officer - YES
3. Memer - YES (all members)
4. Player - YES (only members having updated their characters
5. Initiate - NO


this in order to give only to those which take part in the roster (option 4)

if that is realizable, I say "so thanks"

regards